You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/08/11 13:47:16 UTC

Re: Review Request 60494: Exposed LinuxLauncher cgroups helper.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/#review182695
-----------------------------------------------------------




src/slave/containerizer/mesos/linux_launcher.hpp
Lines 64 (patched)
<https://reviews.apache.org/r/60494/#comment258679>

    Better to move this method to the beginning together with `create()` and `available()`.


- Qian Zhang


On July 11, 2017, 7:11 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60494/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 7:11 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose the LinuxLauncher cgroups helper to generate the cgroups
> path from a container ID. This is needed by the `network/ports`
> isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.hpp e1525231e0a374bc044e929e82b8d051732e97cb 
>   src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931 
> 
> 
> Diff: https://reviews.apache.org/r/60494/diff/8/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>