[GitHub] [solr] cpoerschke commented on a change in pull request #243: SOLR-15480 Added putAll method to Tuple and refactored the copy constructor, merge, and clone methods to use it.

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #243:
URL: https://github.com/apache/solr/pull/243#discussion_r683291659



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java
##########
@@ -276,14 +282,12 @@ public void setMetrics(Map<String, Map<?,?>> metrics) {
 
   public Tuple clone() {
     Tuple clone = new Tuple();
-    clone.fields.putAll(fields);
-    // TODO This doesn't copy EOF/Exception https://issues.apache.org/jira/browse/SOLR-15480
+    clone.putAll(fields);

Review comment:
       maybe shorten to `Tuple clone = new Tuple(this.fields);` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org