You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/02/28 20:59:25 UTC

Review Request 65819: Enforced quota limit in the first resource allocation stage.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65819/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-8456
    https://issues.apache.org/jira/browse/MESOS-8456


Repository: mesos


Description
-------

In the first allocation stage where we allocate resources to
roles with unsatisfied quota guarantee, we used to also allocate
resources that the role has no guarantee for as long as it does
not break the global headroom. With the introduction of quota
limit, when we make these additional "add-on" allocations, we
should also make sure that these won't break the role's own
quota limit.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 58aa83ffdb194bbb9bb518a6b77e23fa49d340f4 


Diff: https://reviews.apache.org/r/65819/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Re: Review Request 65819: Enforced quota limit in the first resource allocation stage.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65819/
-----------------------------------------------------------

(Updated April 6, 2018, 5:42 p.m.)


Review request for mesos, Benjamin Mahler, Kapil Arya, and Till Toenshoff.


Changes
-------

Rebased after refactoring.


Bugs: MESOS-8456
    https://issues.apache.org/jira/browse/MESOS-8456


Repository: mesos


Description (updated)
-------

In the first allocation stage where we allocate resources to
roles with unsatisfied quota guarantee, we used to also allocate
resources that the role has no guarantee set as long as it does
not break the global headroom. With the introduction of quota
limit, when we make these additional "add-on" allocations, we
should also make sure that these won't break the role's own
quota limit.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 32e88952101d8dbbae9728478b1f5663bf46c3bb 


Diff: https://reviews.apache.org/r/65819/diff/2/

Changes: https://reviews.apache.org/r/65819/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu