You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/05/23 07:07:57 UTC
Review Request 21837: Updated the slave to handle status update
acknowledgements from the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21837/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1411
https://issues.apache.org/jira/browse/MESOS-1411
Repository: mesos-git
Description
-------
This is part 1 of MESOS-1411.
This ensures that the slave can handle an acknowledgement that comes from the master, while still handling updates coming directly from the scheduler driver.
I added a check that ignores acknowledgement that arrive while the slave is not registered. Ideally we would ensure that we also don't *send* status updates while we're not registered, but I've left that as is for now (MESOS-1414).
Diffs
-----
src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e
src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7
src/tests/status_update_manager_tests.cpp 8cbfb83b2ef1ecbdcb91a81aa727a3b58009a3f6
Diff: https://reviews.apache.org/r/21837/diff/
Testing
-------
Tests were added in r/21838.
Thanks,
Ben Mahler
Re: Review Request 21837: Updated the slave to handle status update
acknowledgements from the master.
Posted by Vinod Kone <vi...@gmail.com>.
> On May 23, 2014, 6:34 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 1563
> > <https://reviews.apache.org/r/21837/diff/1/?file=589223#file589223line1563>
> >
> > lets to startsWith("master") to be future proof. we might actually want to use UUIDs in pids at some point to tackle cases that you described above.
s/lets to/lets do/
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21837/#review43856
-----------------------------------------------------------
On May 23, 2014, 5:07 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21837/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 5:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1411
> https://issues.apache.org/jira/browse/MESOS-1411
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 of MESOS-1411.
>
> This ensures that the slave can handle an acknowledgement that comes from the master, while still handling updates coming directly from the scheduler driver.
>
> I added a check that ignores acknowledgement that arrive while the slave is not registered. Ideally we would ensure that we also don't *send* status updates while we're not registered, but I've left that as is for now (MESOS-1414).
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e
> src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7
> src/tests/status_update_manager_tests.cpp 8cbfb83b2ef1ecbdcb91a81aa727a3b58009a3f6
>
> Diff: https://reviews.apache.org/r/21837/diff/
>
>
> Testing
> -------
>
> Tests were added in r/21838.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 21837: Updated the slave to handle status update
acknowledgements from the master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21837/#review43856
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/21837/#comment78129>
lets to startsWith("master") to be future proof. we might actually want to use UUIDs in pids at some point to tackle cases that you described above.
- Vinod Kone
On May 23, 2014, 5:07 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21837/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 5:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1411
> https://issues.apache.org/jira/browse/MESOS-1411
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 of MESOS-1411.
>
> This ensures that the slave can handle an acknowledgement that comes from the master, while still handling updates coming directly from the scheduler driver.
>
> I added a check that ignores acknowledgement that arrive while the slave is not registered. Ideally we would ensure that we also don't *send* status updates while we're not registered, but I've left that as is for now (MESOS-1414).
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e
> src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7
> src/tests/status_update_manager_tests.cpp 8cbfb83b2ef1ecbdcb91a81aa727a3b58009a3f6
>
> Diff: https://reviews.apache.org/r/21837/diff/
>
>
> Testing
> -------
>
> Tests were added in r/21838.
>
>
> Thanks,
>
> Ben Mahler
>
>