You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Jialin Qiao <qj...@mails.tsinghua.edu.cn> on 2020/07/11 07:08:37 UTC
Naming of parameters in iotdb-engine.properties
Hi,
I met a scenario that a user set the ttl wrongly as second precision, so he can not query the data.
I checked the parameter description in iotdb-engine.properties, it is described as this:
# Default TTL for storage groups that are not set TTL by statements, in ms. If not set (default),
# the TTL will be unlimited.
# Notice: if this property is changed, previous created storage group which are not set TTL will
# also be affected. And negative values are accepted, which means you can only insert future
# data.
# default_ttl=36000000
I think some users may do not read the descriptions, should we add the unit to the parameter name? E.g., sstable_size_in_mb in Cassandra.
We could rename the default_ttl to default_ttl_in_ms, so as to other parameters.
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
Re: Naming of parameters in iotdb-engine.properties
Posted by Xiangwei Wei <wx...@gmail.com>.
Hi,
+1. Very good point! It will be more intuitive for users.
Xiangdong Huang <sa...@gmail.com> 于2020年7月13日周一 下午4:05写道：
> big +1. not only the time unit, but also the data size unit.
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2020年7月12日周日 上午10:20写道：
>
> > Hi,
> >
> > Yes, keeping them consistent is better.
> >
> > Thanks,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
> >
> > > -----原始邮件-----
> > > 发件人: "孙泽嵩" <sz...@mails.tsinghua.edu.cn>
> > > 发送时间: 2020-07-11 20:18:24 (星期六)
> > > 收件人: dev@iotdb.apache.org
> > > 抄送:
> > > 主题: Re: Naming of parameters in iotdb-engine.properties
> > >
> > > Hi Jialin,
> > >
> > > +1. Really good point.
> > >
> > > Besides, should we keep the unit of same dimension being the same, for
> > example: ms for time, KB for capacity.
> > >
> > > What do you think?
> > >
> > >
> > > Best,
> > > -----------------------------------
> > > Zesong Sun
> > > School of Software, Tsinghua University
> > >
> > > 孙泽嵩
> > > 清华大学 软件学院
> > >
> > > > 2020年7月11日 15:08，Jialin Qiao <qj...@mails.tsinghua.edu.cn> 写道：
> > > >
> > > > Hi,
> > > >
> > > >
> > > > I met a scenario that a user set the ttl wrongly as second precision,
> > so he can not query the data.
> > > >
> > > >
> > > > I checked the parameter description in iotdb-engine.properties, it is
> > described as this:
> > > >
> > > >
> > > > # Default TTL for storage groups that are not set TTL by statements,
> > in ms. If not set (default),
> > > > # the TTL will be unlimited.
> > > > # Notice: if this property is changed, previous created storage group
> > which are not set TTL will
> > > > # also be affected. And negative values are accepted, which means you
> > can only insert future
> > > > # data.
> > > > # default_ttl=36000000
> > > >
> > > >
> > > > I think some users may do not read the descriptions, should we add
> the
> > unit to the parameter name? E.g., sstable_size_in_mb in Cassandra.
> > > >
> > > >
> > > > We could rename the default_ttl to default_ttl_in_ms, so as to other
> > parameters.
> > > >
> > > > Thanks,
> > > > --
> > > > Jialin Qiao
> > > > School of Software, Tsinghua University
> > > >
> > > > 乔嘉林
> > > > 清华大学 软件学院
> > >
> >
>
--
Best,
Xiangwei Wei
Re: Naming of parameters in iotdb-engine.properties
Posted by Xiangdong Huang <sa...@gmail.com>.
big +1. not only the time unit, but also the data size unit.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2020年7月12日周日 上午10:20写道：
> Hi,
>
> Yes, keeping them consistent is better.
>
> Thanks,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "孙泽嵩" <sz...@mails.tsinghua.edu.cn>
> > 发送时间: 2020-07-11 20:18:24 (星期六)
> > 收件人: dev@iotdb.apache.org
> > 抄送:
> > 主题: Re: Naming of parameters in iotdb-engine.properties
> >
> > Hi Jialin,
> >
> > +1. Really good point.
> >
> > Besides, should we keep the unit of same dimension being the same, for
> example: ms for time, KB for capacity.
> >
> > What do you think?
> >
> >
> > Best,
> > -----------------------------------
> > Zesong Sun
> > School of Software, Tsinghua University
> >
> > 孙泽嵩
> > 清华大学 软件学院
> >
> > > 2020年7月11日 15:08，Jialin Qiao <qj...@mails.tsinghua.edu.cn> 写道：
> > >
> > > Hi,
> > >
> > >
> > > I met a scenario that a user set the ttl wrongly as second precision,
> so he can not query the data.
> > >
> > >
> > > I checked the parameter description in iotdb-engine.properties, it is
> described as this:
> > >
> > >
> > > # Default TTL for storage groups that are not set TTL by statements,
> in ms. If not set (default),
> > > # the TTL will be unlimited.
> > > # Notice: if this property is changed, previous created storage group
> which are not set TTL will
> > > # also be affected. And negative values are accepted, which means you
> can only insert future
> > > # data.
> > > # default_ttl=36000000
> > >
> > >
> > > I think some users may do not read the descriptions, should we add the
> unit to the parameter name? E.g., sstable_size_in_mb in Cassandra.
> > >
> > >
> > > We could rename the default_ttl to default_ttl_in_ms, so as to other
> parameters.
> > >
> > > Thanks,
> > > --
> > > Jialin Qiao
> > > School of Software, Tsinghua University
> > >
> > > 乔嘉林
> > > 清华大学 软件学院
> >
>
Re: Naming of parameters in iotdb-engine.properties
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi,
Yes, keeping them consistent is better.
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "孙泽嵩" <sz...@mails.tsinghua.edu.cn>
> 发送时间: 2020-07-11 20:18:24 (星期六)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: Naming of parameters in iotdb-engine.properties
>
> Hi Jialin,
>
> +1. Really good point.
>
> Besides, should we keep the unit of same dimension being the same, for example: ms for time, KB for capacity.
>
> What do you think?
>
>
> Best,
> -----------------------------------
> Zesong Sun
> School of Software, Tsinghua University
>
> 孙泽嵩
> 清华大学 软件学院
>
> > 2020年7月11日 15:08，Jialin Qiao <qj...@mails.tsinghua.edu.cn> 写道：
> >
> > Hi,
> >
> >
> > I met a scenario that a user set the ttl wrongly as second precision, so he can not query the data.
> >
> >
> > I checked the parameter description in iotdb-engine.properties, it is described as this:
> >
> >
> > # Default TTL for storage groups that are not set TTL by statements, in ms. If not set (default),
> > # the TTL will be unlimited.
> > # Notice: if this property is changed, previous created storage group which are not set TTL will
> > # also be affected. And negative values are accepted, which means you can only insert future
> > # data.
> > # default_ttl=36000000
> >
> >
> > I think some users may do not read the descriptions, should we add the unit to the parameter name? E.g., sstable_size_in_mb in Cassandra.
> >
> >
> > We could rename the default_ttl to default_ttl_in_ms, so as to other parameters.
> >
> > Thanks,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
>
Re: Naming of parameters in iotdb-engine.properties
Posted by 孙泽嵩 <sz...@mails.tsinghua.edu.cn>.
Hi Jialin,
+1. Really good point.
Besides, should we keep the unit of same dimension being the same, for example: ms for time, KB for capacity.
What do you think?
Best,
-----------------------------------
Zesong Sun
School of Software, Tsinghua University
孙泽嵩
清华大学 软件学院
> 2020年7月11日 15:08，Jialin Qiao <qj...@mails.tsinghua.edu.cn> 写道：
>
> Hi,
>
>
> I met a scenario that a user set the ttl wrongly as second precision, so he can not query the data.
>
>
> I checked the parameter description in iotdb-engine.properties, it is described as this:
>
>
> # Default TTL for storage groups that are not set TTL by statements, in ms. If not set (default),
> # the TTL will be unlimited.
> # Notice: if this property is changed, previous created storage group which are not set TTL will
> # also be affected. And negative values are accepted, which means you can only insert future
> # data.
> # default_ttl=36000000
>
>
> I think some users may do not read the descriptions, should we add the unit to the parameter name? E.g., sstable_size_in_mb in Cassandra.
>
>
> We could rename the default_ttl to default_ttl_in_ms, so as to other parameters.
>
> Thanks,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院