You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/28 17:55:53 UTC

[GitHub] mistercrunch commented on issue #4500: [payload] Fixing regression introduced in ##4396

mistercrunch commented on issue #4500: [payload] Fixing regression introduced in ##4396
URL: https://github.com/apache/incubator-superset/pull/4500#issuecomment-369325413
 
 
   I feel like we need some unit tests here making sure errors bubble up somehow. It should be easy to generate a `No Data` exception with a filter. For the other test case that is more representative (currently says `No Data` but should say something else) you could reference a metric that does not exist in the query, and change the `query` method to make sure it actually raises a specific message `Metric referenced does not exist anymore` and make sure it comes through.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services