[GitHub] [flink] becketqin commented on a change in pull request #13512: [FLINK-19457][core] Add a number sequence generating source for the New Source API.

[GitBox <gi...@apache.org>]

becketqin commented on a change in pull request #13512:
URL: https://github.com/apache/flink/pull/13512#discussion_r497868184



##########
File path: flink-core/src/test/java/org/apache/flink/api/connector/source/lib/NumberSequenceSourceTest.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.connector.source.lib;
+
+import org.apache.flink.api.connector.source.SourceReader;
+import org.apache.flink.api.connector.source.mocks.TestingReaderContext;
+import org.apache.flink.api.connector.source.mocks.TestingReaderOutput;
+import org.apache.flink.core.io.InputStatus;
+
+import org.junit.Test;
+
+import java.util.Arrays;
+import java.util.List;
+
+import static org.junit.Assert.fail;
+
+/**
+ * Tests for the {@link NumberSequenceSource}.
+ */
+public class NumberSequenceSourceTest {
+
+	@Test
+	public void testReaderCheckpoints() throws Exception {

Review comment:
       It seems that we should not reduce test time by skipping reasonable tests? The concern I has was that if there is another test using the `NumberSequenceSource` failed due to a bug in this source. The author of that test may have to look into the code of this source, which seems something we would like to avoid by having tests here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org