You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by ja...@apache.org on 2026/07/05 05:33:09 UTC
(grails-core) 10/11: Remove stale Hibernate 7 service spec TODOs
This is an automated email from the ASF dual-hosted git repository.
jamesfredley pushed a commit to branch cleanup/8.0-h7-todo-doc-cleanup
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 38e037834fa03d6e81e4ea57aac88f2d4dd824b6
Author: James Fredley <ja...@users.noreply.github.com>
AuthorDate: Sun Jul 5 00:59:08 2026 -0400
Remove stale Hibernate 7 service spec TODOs
Assisted-by: Hephaestus:openai/gpt-5.5
---
.../gorm/tests/compositeid/GlobalConstraintWithCompositeIdSpec.groovy | 1 -
.../src/test/groovy/grails/gorm/tests/services/DataServiceSpec.groovy | 3 +--
.../groovy/org/grails/orm/hibernate/HibernateGormStaticApiSpec.groovy | 1 -
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/compositeid/GlobalConstraintWithCompositeIdSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/compositeid/GlobalConstraintWithCompositeIdSpec.groovy
index a0cfcbdf2a..7667f41097 100644
--- a/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/compositeid/GlobalConstraintWithCompositeIdSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/compositeid/GlobalConstraintWithCompositeIdSpec.groovy
@@ -30,7 +30,6 @@ import spock.lang.Issue
/**
* Created by graemerocher on 17/02/2017.
*/
-//TODO 2025-04-17 CompositeId not working
class GlobalConstraintWithCompositeIdSpec extends HibernateGormDatastoreSpec {
def setupSpec() {
diff --git a/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/services/DataServiceSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/services/DataServiceSpec.groovy
index 3992e21350..04d37623e1 100644
--- a/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/services/DataServiceSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/services/DataServiceSpec.groovy
@@ -401,8 +401,7 @@ class DataServiceSpec extends Specification {
Product product = productService.findByName("Apple").first()
then:
- //TODO I am not sure this is the right assertion related to the bug reported
- //product.attributes.isInitialized()
+ // Accessing the collection verifies that @Join returned the expected initialized association data.
product.attributes.size() == 1
product.attributes.iterator().next() == attribute
diff --git a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/HibernateGormStaticApiSpec.groovy b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/HibernateGormStaticApiSpec.groovy
index 8b64a33847..689a9dffb3 100644
--- a/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/HibernateGormStaticApiSpec.groovy
+++ b/grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/HibernateGormStaticApiSpec.groovy
@@ -365,7 +365,6 @@ class HibernateGormStaticApiSpec extends HibernateGormDatastoreSpec {
thrown(IllegalArgumentException)
}
- //TODO no transaction is in progress
void "Test withNewSession"() {
given:
new HibernateGormStaticApiEntity(name: "outer").save(flush: true, failOnError: true)