You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/17 06:12:19 UTC

[GitHub] [netbeans] jtulach commented on a change in pull request #2761: Towards building just on JDK11.

jtulach commented on a change in pull request #2761:
URL: https://github.com/apache/netbeans/pull/2761#discussion_r577349817



##########
File path: platform/libs.javafx/manifest.mf
##########
@@ -38,5 +38,4 @@ OpenIDE-Module-Provides: javafx.animation,
     javafx.util,
     javafx.util.converter,
     netscape.javascript
-Class-Path: ${java.home}/lib/ext/jfxrt.jar
-
+Class-Path: %24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar

Review comment:
       Very ugly, I agree. I was also considering defining some new token instead of `${java.home}`, but that would mean API changes, versioning, etc. At the end I decided to apply a [simple bugfix](https://github.com/apache/netbeans/pull/2761#discussion_r577187116).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists