You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/01/25 17:58:45 UTC
[jira] Created: (CASSANDRA-2051) Fixes for multi-datacenter writes
Fixes for multi-datacenter writes
---------------------------------
Key: CASSANDRA-2051
URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7.1
Reporter: Jonathan Ellis
Fix For: 0.7.1
Attachments: rep_fix_02.patch
Copied from CASSANDRA-982:
* Message::removeHeader
message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
* db/RowMutationVerbHandler::forwardToLocalNodes
set correct destination address for sendOneWay
* response(ReadResponse result) added to DatacenterReadCallback
otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
* FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
(if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-2051) Fixes for multi-datacenter writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2051:
--------------------------------------
Attachment: 2051-2.txt
patch 2 re-organizes the loops in SP::sendMessages to make ivan's fix a little more clear. (with the side benefit that we now call String.equals once per DC instead of once per message.)
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2051) Fixes for multi-datacenter
writes
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986654#action_12986654 ]
T Jake Luciani commented on CASSANDRA-2051:
-------------------------------------------
Looks good +1, thanks for testing this ivan
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Assignee: ivan
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-2051) Fixes for multi-datacenter writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-2051.
---------------------------------------
Resolution: Fixed
Reviewer: jbellis
committed. thanks Ivan and Jake!
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Assignee: ivan
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2051) Fixes for multi-datacenter
writes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986671#action_12986671 ]
Hudson commented on CASSANDRA-2051:
-----------------------------------
Integrated in Cassandra-0.7 #210 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/210/])
clean out forward headers from message between loops
patch by ivancso and jbellis; reviewed by tjake for CASSANDRA-2051
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Assignee: ivan
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-2051) Fixes for multi-datacenter writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-2051:
-----------------------------------------
Assignee: ivan
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Assignee: ivan
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2051) Fixes for multi-datacenter
writes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986598#action_12986598 ]
Hudson commented on CASSANDRA-2051:
-----------------------------------
Integrated in Cassandra-0.7 #207 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/207/])
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Assignee: ivan
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2051) Fixes for multi-datacenter
writes
Posted by "ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986648#action_12986648 ]
ivan commented on CASSANDRA-2051:
---------------------------------
patch 2 much better. thanks Jonathan. ;)
i pulled latest trunk and applied patch in 2051-2.txt.
it seems that communication between nodes and DCs works as expected.
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Assignee: ivan
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-2051) Fixes for multi-datacenter writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2051:
--------------------------------------
Attachment: rep_fix_02.patch
Ivan's patch
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Fix For: 0.7.1
>
> Attachments: rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-2051) Fixes for multi-datacenter
writes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986526#action_12986526 ]
Jonathan Ellis commented on CASSANDRA-2051:
-------------------------------------------
committed everything else from ivan's patch in r1063361
> Fixes for multi-datacenter writes
> ---------------------------------
>
> Key: CASSANDRA-2051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2051
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Jonathan Ellis
> Assignee: ivan
> Fix For: 0.7.1
>
> Attachments: 2051-2.txt, rep_fix_02.patch
>
>
> Copied from CASSANDRA-982:
> * Message::removeHeader
> message.setHeader(RowMutation.FORWARD_HEADER, null) throws NullPointerException
> * db/RowMutationVerbHandler::forwardToLocalNodes
> set correct destination address for sendOneWay
> * response(ReadResponse result) added to DatacenterReadCallback
> otherwise ReadCallback will process local results and condition will be never signaled in DatacenterReadCallback
> * FORWARD header removed in StorageProxy::sendMessages if dataCenter equals to localDataCenter
> (if a non local DC processed before local DC FORWARD header will be set when unhintedMessage used in sendToHintedEndpoints. one instance of Message used for unhintedMessage)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.