You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "17krishna8 (via GitHub)" <gi...@apache.org> on 2026/10/16 15:49:59 UTC

[PR] Fall back to the default charset when the request charset name is not a legal name [wicket]

17krishna8 opened a new pull request, #1675:
URL: https://github.com/apache/wicket/pull/1675

   `Charset.forName()` throws `IllegalCharsetNameException` for a name that is not even a legal charset name, next to `UnsupportedCharsetException` for a legal but unknown one, and only the latter was caught in `RequestUtils.getCharset()`.
   
   The name comes from the character encoding of the servlet request, which a client influences through the charset parameter of the `Content-Type` header (whether such a name reaches the application differs between containers), so the value could surface as an unhandled runtime exception while the request charset is resolved.
   
   Both exceptions are now handled the same way: the encoding is unknown and the default charset is used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fall back to the default charset when the request charset name is not a legal name [wicket]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1675:
URL: https://github.com/apache/wicket/pull/1675#issuecomment-6238079659

   ## [Codecov](https://app.codecov.io/gh/apache/wicket/pull/1675?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.96%. Comparing base ([`5cbd566`](https://app.codecov.io/gh/apache/wicket/commit/5cbd5661255b3e5498e40d093fa58e83085832ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`95492d8`](https://app.codecov.io/gh/apache/wicket/commit/95492d87d45c768cc01425e54876d76194355224?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1675   +/-   ##
   =========================================
     Coverage     61.96%   61.96%           
   - Complexity    11285    11286    +1     
   =========================================
     Files          1250     1250           
     Lines         48437    48437           
     Branches       6796     6796           
   =========================================
   + Hits          30014    30015    +1     
     Misses        15729    15729           
   + Partials       2694     2693    -1     
   ```
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fall back to the default charset when the request charset name is not a legal name [wicket]

Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1675:
URL: https://github.com/apache/wicket/pull/1675#issuecomment-6295870722

   I'm coming back to this and thinking that throwing an error is more correct and defensible. 
   
   Help me understand the thinking of falling back to default vs throwing error?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fall back to the default charset when the request charset name is not a legal name [wicket]

Posted by "bitstorm (via GitHub)" <gi...@apache.org>.
bitstorm merged PR #1675:
URL: https://github.com/apache/wicket/pull/1675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fall back to the default charset when the request charset name is not a legal name [wicket]

Posted by "17krishna8 (via GitHub)" <gi...@apache.org>.
17krishna8 commented on PR #1675:
URL: https://github.com/apache/wicket/pull/1675#issuecomment-6229813472

   Thanks! I left the multipart part for a follow-up so this one can go in as is: #1677.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org