You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/28 16:58:41 UTC

[GitHub] hvanhovell opened a new pull request #23397: [SPARK-26495][SQL] Simplify the SelectedField extractor.

hvanhovell opened a new pull request #23397: [SPARK-26495][SQL] Simplify the SelectedField extractor.
URL: https://github.com/apache/spark/pull/23397
 
 
   ## What changes were proposed in this pull request?
   The current `SelectedField` extractor is somewhat complicated and it seems to be handling cases that should be handled automatically:
   
   - `GetArrayItem(child: GetStructFieldObject())`
   - `GetArrayStructFields(child: GetArrayStructFields())`
   - `GetMap(value: GetStructFieldObject())`
   
   This PR removes those cases and simplifies the extractor by passing down the data type instead of a field.
   
   ## How was this patch tested?
   Existing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org