You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/31 19:10:59 UTC
[GitHub] [thrift] slicking opened a new pull request #2496: THRIFT-5492: Add readEnd to TBufferedTransport
slicking opened a new pull request #2496:
URL: https://github.com/apache/thrift/pull/2496
client: cpp
Add a readEnd implementation to TBufferedTransport which resets the consumed
message size. Without this it was noticed that calls to the transport's
consume method would slowly decrement the remainingMessageSize_ and the
remainingMessageSize_ was never reset. A client could send many messages to
the server, eventually bringing remainingMessageSize_ below zero causing an
EOD_OF_FILE exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2496: THRIFT-5492: Add readEnd to TBufferedTransport
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2496:
URL: https://github.com/apache/thrift/pull/2496#issuecomment-1007940674
<html>
<body>
<!--StartFragment--><p dir="auto" style="box-sizing: border-box; margin-top: 0px; margin-bottom: 16px; color: rgb(36, 41, 47); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">This stage<span> </span><strong style="box-sizing: border-box; font-weight: 600;">failed</strong>.</p>
Job | Xcode | ENV | OS | State
-- | -- | -- | -- | --
7919.3 | | SCRIPT="cmake.sh" | Linux | failed
7919.4 | | SCRIPT="cmake.sh" | Linux | failed
7919.5 | | SCRIPT="cmake.sh" | Linux | failed
7919.6 | | SCRIPT="cmake.sh" | Linux | failed
7919.7 | | SCRIPT="cmake.sh" | Linux | failed
7919.8 | | SCRIPT="cmake.sh" | Linux | failed
7919.9 | | SCRIPT="cmake.sh" | Linux | failed
7919.10 | | SCRIPT="cmake.sh" | Linux | failed
7919.11 | | SCRIPT="cmake.sh" | Linux | passed
7919.12 | | SCRIPT="cmake.sh" | Linux | failed
7919.13 | | SCRIPT="cmake.sh" | Linux | passed
7919.14 | xcode11.3 | SCRIPT="cmake.sh" | macOS | passed
<!--EndFragment-->
</body>
</html>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] slicking commented on pull request #2496: THRIFT-5492: Add readEnd to TBufferedTransport
Posted by GitBox <gi...@apache.org>.
slicking commented on pull request #2496:
URL: https://github.com/apache/thrift/pull/2496#issuecomment-1068691465
@Jens-G thanks for pointing out the failures. Looking at several of them it appears to be because I added to test/StessTest.thrift but only updated test/cpp/src/StessTest.cpp and NOT lib/d/test/stress_test_server.d so there is an unimplemented function.
The fix I made was only under the c++ server; let me see if adding a test under lib/cpp/test/ would be better contained and cover only the c++ server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org