You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jiayuasu (via GitHub)" <gi...@apache.org> on 2026/03/05 02:11:31 UTC
[PR] [GH-2678] Add SVG visuals for affine transformation functions (Phase 8) [sedona]
jiayuasu opened a new pull request, #2690:
URL: https://github.com/apache/sedona/pull/2690
## Description
Phase 8 of fixing #2678 - adds SVG visual illustrations for all 7 **Affine Transformation** functions.
### Approach
Uses an **overlay visualization** where input (blue dashed) and result (green solid) are drawn in the same coordinate space, making the geometric transformation immediately visible:
| Function | Visualization |
|----------|---------------|
| ST_Affine | Horizontal shear transform on a rectangle |
| ST_Rotate | 45 degree counter-clockwise rotation of L-shape around centroid |
| ST_RotateX | 3D rotation around X-axis showing Y compression in 2D projection |
| ST_RotateY | 3D rotation around Y-axis showing X compression in 2D projection |
| ST_Scale | Non-uniform scaling (1.5x, 2y) of L-shape from origin |
| ST_ScaleGeom | Scaling relative to centroid (0.5x, 0.75y) of house shape |
| ST_Translate | Translation of L-shape by (deltaX=2, deltaY=1.5) |
### Files changed
- **7 new SVGs** in `docs/image/ST_*/ST_*.svg`
- **21 doc files** updated (7 SQL + 7 Flink + 7 Snowflake)
### Related
- Issue: #2678
- Phase 1 (Predicates): #2681 merged
- Phase 2 (Overlays): #2682 merged
- Phase 3 (Processing): #2683 merged
- Phase 4 (Measurement): #2684 merged
- Phase 5 (Editors): #2686
- Phase 6 (Accessors): #2687
- Phase 7 (Validation): #2689 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG visuals for affine transformation functions (Phase 8) [sedona]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2690:
URL: https://github.com/apache/sedona/pull/2690#discussion_r2887182068
##########
docs/api/sql/Affine-Transformations/ST_Rotate.md:
##########
@@ -21,6 +21,8 @@
Introduction: Rotates a geometry by a specified angle in radians counter-clockwise around a given origin point. The origin for rotation can be specified as either a POINT geometry or x and y coordinates. If the origin is not specified, the geometry is rotated around POINT(0 0).
+
+
Formats;
Review Comment:
The section label uses `Formats;`, which looks like a typo/punctuation error. For consistency with other docs headings, change this to `Formats:`.
```suggestion
Formats:
```
##########
docs/api/snowflake/vector-data/Affine-Transformations/ST_Rotate.md:
##########
@@ -21,6 +21,8 @@
Introduction: Rotates a geometry by a specified angle in radians counter-clockwise around a given origin point. The origin for rotation can be specified as either a POINT geometry or x and y coordinates. If the origin is not specified, the geometry is rotated around POINT(0 0).
+
+
Formats;
Review Comment:
The section label uses `Formats;`, which looks like a typo/punctuation error. For consistency with other docs headings, change this to `Formats:`.
```suggestion
Formats:
```
##########
docs/api/flink/Affine-Transformations/ST_Rotate.md:
##########
@@ -21,6 +21,8 @@
Introduction: Rotates a geometry by a specified angle in radians counter-clockwise around a given origin point. The origin for rotation can be specified as either a POINT geometry or x and y coordinates. If the origin is not specified, the geometry is rotated around POINT(0 0).
+
+
Formats;
Review Comment:
The section label uses `Formats;`, which looks like a typo/punctuation error. For consistency with other docs headings, change this to `Formats:`.
```suggestion
Formats:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG visuals for affine transformation functions (Phase 8) [sedona]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2690:
URL: https://github.com/apache/sedona/pull/2690#discussion_r2887726811
##########
docs/api/snowflake/vector-data/Affine-Transformations/ST_Translate.md:
##########
@@ -26,6 +26,8 @@ If the geometry is 2D, and a deltaZ parameter is specified, no change is done to
If the geometry is empty, no change is done to it.
If the given geometry contains sub-geometries (GEOMETRY COLLECTION, MULTI POLYGON/LINE/POINT), all underlying geometries are individually translated.
+
+
Format: `ST_Translate(geometry: geometry, deltaX: deltaX, deltaY: deltaY, deltaZ: deltaZ)`
Review Comment:
The Snowflake doc's format signature lists parameter names as if they were types (`deltaX: deltaX`, etc.). This appears inconsistent with the other Snowflake affine transformation docs (which use `Double`) and with the SQL/Flink variants. Please correct the signature to use the actual parameter types (e.g., `deltaX: Double`, `deltaY: Double`, `deltaZ: Double`).
```suggestion
Format: `ST_Translate(geometry: Geometry, deltaX: Double, deltaY: Double, deltaZ: Double)`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG visuals for affine transformation functions (Phase 8) [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2690:
URL: https://github.com/apache/sedona/pull/2690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org