You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by jo...@apache.org on 2008/09/19 02:02:21 UTC
svn commit: r696860 - in
/poi/trunk/src/java/org/apache/poi/hssf/record/formula: OperationPtg.java
Ref3DPtg.java
Author: josh
Date: Thu Sep 18 17:02:21 2008
New Revision: 696860
URL: http://svn.apache.org/viewvc?rev=696860&view=rev
Log:
code clean-up (removed compiler warnings/unused methods)
Modified:
poi/trunk/src/java/org/apache/poi/hssf/record/formula/OperationPtg.java
poi/trunk/src/java/org/apache/poi/hssf/record/formula/Ref3DPtg.java
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/formula/OperationPtg.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/formula/OperationPtg.java?rev=696860&r1=696859&r2=696860&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/formula/OperationPtg.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/formula/OperationPtg.java Thu Sep 18 17:02:21 2008
@@ -17,8 +17,6 @@
package org.apache.poi.hssf.record.formula;
-import org.apache.poi.ss.formula.FormulaRenderingWorkbook;
-
/**
* defines a Ptg that is an operation instead of an operand
* @author andy
@@ -42,16 +40,10 @@
public abstract int getNumberOfOperands();
public byte getDefaultOperandClass() {
- return Ptg.CLASS_VALUE;
- }
+ return Ptg.CLASS_VALUE;
+ }
public final int getType() {
- // TODO remove "int getType();" from Eval hierarchy
- throw new RuntimeException("remove this method");
+ // TODO remove "int getType();" from Eval hierarchy
+ throw new RuntimeException("remove this method");
}
-
- public String toFormulaString(FormulaRenderingWorkbook book) {
- // TODO Auto-generated method stub
- return null;
- }
-
}
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/formula/Ref3DPtg.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/formula/Ref3DPtg.java?rev=696860&r1=696859&r2=696860&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/formula/Ref3DPtg.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/formula/Ref3DPtg.java Thu Sep 18 17:02:21 2008
@@ -18,7 +18,6 @@
package org.apache.poi.hssf.record.formula;
import org.apache.poi.hssf.record.RecordInputStream;
-import org.apache.poi.hssf.usermodel.HSSFWorkbook;
import org.apache.poi.hssf.util.CellReference;
import org.apache.poi.ss.formula.WorkbookDependentFormula;
import org.apache.poi.ss.formula.FormulaRenderingWorkbook;
@@ -67,9 +66,9 @@
}
public void writeBytes(byte [] array, int offset) {
- LittleEndian.putByte(array, 0 + offset, sid + getPtgClass());
- LittleEndian.putUShort(array, 1 + offset, getExternSheetIndex());
- writeCoordinates(array, offset + 3);
+ LittleEndian.putByte(array, 0 + offset, sid + getPtgClass());
+ LittleEndian.putUShort(array, 1 + offset, getExternSheetIndex());
+ writeCoordinates(array, offset + 3);
}
public int getSize() {
@@ -89,9 +88,9 @@
* formulas. The sheet name will get properly delimited if required.
*/
public String toFormulaString(FormulaRenderingWorkbook book) {
- return ExternSheetNameResolver.prependSheetName(book, field_1_index_extern_sheet, formatReferenceAsString());
+ return ExternSheetNameResolver.prependSheetName(book, field_1_index_extern_sheet, formatReferenceAsString());
+ }
+ public String toFormulaString() {
+ throw new RuntimeException("3D references need a workbook to determine formula text");
}
- public String toFormulaString() {
- throw new RuntimeException("3D references need a workbook to determine formula text");
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org