You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2020/05/21 13:22:34 UTC

Review Request 72538: TestMiniLlapLocalCliDriver should be the default driver for q tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72538/
-----------------------------------------------------------

Review request for hive, Jesús Camacho Rodríguez and Krisztian Kasa.


Bugs: HIVE-23510
    https://issues.apache.org/jira/browse/HIVE-23510


Repository: hive-git


Description
-------

Set TestMiniLlapLocalCliDriver as the default driver. For now the few tests still processed by TestCliDriver should be marked in the testconfiguration.properties, until it is completely eliminated.


Diffs
-----

  itests/src/test/resources/testconfiguration.properties e7c3e432ee 
  itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java d7f519fac2 
  ql/src/test/results/clientpositive/llap/quotedid_basic_standard.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/quotedid_basic_standard.q.out 2374dc84ea 


Diff: https://reviews.apache.org/r/72538/diff/1/


Testing
-------


Thanks,

Miklos Gergely


Re: Review Request 72538: TestMiniLlapLocalCliDriver should be the default driver for q tests

Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72538/#review220851
-----------------------------------------------------------


Ship it!




LGTM

- Krisztian Kasa


On May 21, 2020, 1:22 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72538/
> -----------------------------------------------------------
> 
> (Updated May 21, 2020, 1:22 p.m.)
> 
> 
> Review request for hive, Jesús Camacho Rodríguez and Krisztian Kasa.
> 
> 
> Bugs: HIVE-23510
>     https://issues.apache.org/jira/browse/HIVE-23510
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Set TestMiniLlapLocalCliDriver as the default driver. For now the few tests still processed by TestCliDriver should be marked in the testconfiguration.properties, until it is completely eliminated.
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties e7c3e432ee 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java d7f519fac2 
>   ql/src/test/results/clientpositive/llap/quotedid_basic_standard.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/quotedid_basic_standard.q.out 2374dc84ea 
> 
> 
> Diff: https://reviews.apache.org/r/72538/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>