You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/14 23:15:10 UTC
[GitHub] [incubator-druid] jon-wei opened a new pull request #7661: Fix
compareAndSwap() in SQLMetadataConnector
jon-wei opened a new pull request #7661: Fix compareAndSwap() in SQLMetadataConnector
URL: https://github.com/apache/incubator-druid/pull/7661
This PR fixes SQLMetadataConnector.compareAndSwap() by adding " FOR UPDATE" to the initial read and using REPEATABLE_READ isolation level for the transaction.
This method is used by `druid-basic-security` extension APIs, and the broken CAS method was causing issues where some concurrent update requests (such as assigning roles to a user) failed to take effect.
A test is added that concurrently makes 100 role assignment requests and later concurrently removes the 100 roles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org