You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "jinxxxoid (via GitHub)" <gi...@apache.org> on 2025/07/31 13:13:50 UTC
[PR] IGNITE-26082 Update Streaming API examples [ignite-3]
jinxxxoid opened a new pull request, #6348:
URL: https://github.com/apache/ignite-3/pull/6348
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26082 Update Streaming API examples [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego merged PR #6348:
URL: https://github.com/apache/ignite-3/pull/6348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26082 Update Streaming API examples [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #6348:
URL: https://github.com/apache/ignite-3/pull/6348#discussion_r2259865422
##########
examples/src/main/java/org/apache/ignite/example/streaming/Account.java:
##########
@@ -15,48 +15,53 @@
* limitations under the License.
*/
-package org.apache.ignite.example.streaming.pojo;
+package org.apache.ignite.example.streaming;
-/**
- * POJO class that represents Account value.
- */
-public class AccountValue {
- /** Name. */
- private String name;
+public class Account {
+ private int id;
+ private String name;
+ private long balance;
+ private boolean active;
- /** Balance. */
- private long balance;
+ public Account() {
+ }
- /** Is account active. */
- private boolean active;
+ public Account(int id, String name, long balance, boolean active) {
+ this.id = id;
+ this.name = name;
+ this.balance = balance;
+ this.active = active;
+ }
+
+ public Account(int id) {
+ this.id = id;
+ }
+
+ public int getId() {
+ return id;
+ }
+ public void setId(int id) {
Review Comment:
It would be nice to have an empty line before this method (here and below).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org