You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2024/05/24 22:49:30 UTC
[PR] enable BigQueryIO read throttling detection for Python SDK [beam]
Abacn opened a new pull request, #31404:
URL: https://github.com/apache/beam/pull/31404
Before (using a gcp project of limited quota):
<img width="852" alt="image" src="https://github.com/apache/beam/assets/8010435/ba8bf7fa-8fbe-4c4e-bd44-a41f5c0e7764">
upscale to 270+ worker aggressively, before cancel the job
After (note: backend change not yet rolled out on prod):
(up-hill part, max worker=181)
<img width="859" alt="image" src="https://github.com/apache/beam/assets/8010435/ef11b1b8-954a-416a-be6c-8b129d9584d2">
(down-hill part)
<img width="853" alt="image" src="https://github.com/apache/beam/assets/8010435/be766d98-5e54-4643-b2c3-59677415e6bb">
note: autoscaler won't kill active worker until current work item finish, and there is a 6 min lapse from worker started to reactive downscale working, see https://github.com/apache/beam/pull/31253#issuecomment-2118608486
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enable BigQueryIO read throttling detection for Python SDK [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31404:
URL: https://github.com/apache/beam/pull/31404#issuecomment-2130548849
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @shunping for label python.
R: @shunping for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enable BigQueryIO read throttling detection for Python SDK [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31404:
URL: https://github.com/apache/beam/pull/31404#issuecomment-2135249423
R: @shunping @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enable BigQueryIO read throttling detection for Python SDK [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31404:
URL: https://github.com/apache/beam/pull/31404#issuecomment-2135252218
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enable BigQueryIO read throttling detection for Python SDK [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31404:
URL: https://github.com/apache/beam/pull/31404#discussion_r1614114675
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1186,11 +1186,19 @@ def split(self, desired_bundle_size, start_position=None, stop_position=None):
parent=parent,
read_session=requested_session,
max_stream_count=stream_count)
+ if self.use_native_datetime:
+ display_schema = "Arrow Schema:" + str(read_session.arrow_schema)
+ else:
+ display_schema = "Avro Schema:" + str(read_session.avro_schema)
_LOGGER.info(
Review Comment:
this is to make this log readable. Before it was printing raw proto message truncated on streams URLs. Now it only prints the number of streams returned and the key fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enable BigQueryIO Storage Read throttling detection for Python SDK [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31404:
URL: https://github.com/apache/beam/pull/31404#issuecomment-2136277404
Python ML test failure on 2/5 python versions untelated to the change. Merging for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] enable BigQueryIO Storage Read throttling detection for Python SDK [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #31404:
URL: https://github.com/apache/beam/pull/31404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org