[GitHub] [hbase] bharathv commented on a change in pull request #3382: HBASE-25998: Redo synchronization in SyncFuture [DRAFT]

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #3382:
URL: https://github.com/apache/hbase/pull/3382#discussion_r650598109



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SyncFuture.java
##########
@@ -44,19 +45,22 @@
  */
 @InterfaceAudience.Private
 class SyncFuture {
-  // Implementation notes: I tried using a cyclicbarrier in here for handler and sync threads
-  // to coordinate on but it did not give any obvious advantage and some issues with order in which
-  // events happen.
+
   private static final long NOT_DONE = -1L;
+  private Thread t;
 
-  /**
-   * The transaction id of this operation, monotonically increases.
-   */
-  private long txid;
+  // Lock protecting the thread safe fields
+  ReentrantLock doneLock;
+  // Condition to wait on for client threads.
+  Condition isDone;

Review comment:
       Ack, done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org