[GitHub] [tvm] alter-xp commented on a change in pull request #9113: [Frontend][ONNX] add onnx ConcatFromSequence and SequenceConstruct

[GitBox <gi...@apache.org>]

alter-xp commented on a change in pull request #9113:
URL: https://github.com/apache/tvm/pull/9113#discussion_r717501981



##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -1279,6 +1293,16 @@ def _impl_v1(cls, inputs, attr, params):
         return inputs[len(inputs) - 1]
 
 
+class SequenceConstruct(OnnxOpConverter):
+    """Operator converter for SequenceConstruct"""
+
+    @classmethod
+    def _impl_v11(cls, inputs, attr, params):
+        if len(inputs) == 1:
+            raise ValueError("Expect 2 or more inputs")
+        return _op.Tuple(inputs)

Review comment:
       thanks for comments. I'm not particularly sure whether the number of elements can be dynamic, but it seems not. and I‘m not clear about which op can be used as the tensor array you mentioned. you mean TupleWrapper？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org