[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22855#discussion_r230052150
  
    --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -84,6 +85,7 @@ class KryoSerializer(conf: SparkConf)
       private val avroSchemas = conf.getAvroSchema
       // whether to use unsafe based IO for serialization
       private val useUnsafe = conf.getBoolean("spark.kryo.unsafe", false)
    +  private val usePool = conf.getBoolean("spark.kryo.pool", false)
    --- End diff --
    
    I would not document it. This is just a safety valve. In theory, there's no reason to disable this nor would a caller know why to disable it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org