[GitHub] [cloudstack] nvazquez commented on a change in pull request #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused
URL: https://github.com/apache/cloudstack/pull/3617#discussion_r350678427
 
 

 ##########
 File path: server/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java
 ##########
 @@ -136,7 +136,7 @@ public int compare(Long x, Long y) {
         }
         final List <Host> agentBasedHosts = new ArrayList<>();
         for (final Host host : allHosts) {
-            if (host == null || host.getResourceState() != ResourceState.Enabled) {
+            if (host == null || host.getResourceState() == ResourceState.Creating || host.getResourceState() == ResourceState.Error) {
 
 Review comment:
   Hi @GabrielBrascher sorry for the late response Yes, as Andrija mentions those states are considered as well. The table added is great to show multiple use cases, thanks @andrijapanicsb 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services