[ofbiz-framework] branch release22.01 updated: Fixed: NullPointerException in plugin 'projectMgr' when listing TimeSheets (OFBIZ-12593)

[jl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch release22.01
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release22.01 by this push:
     new e7af1f7  Fixed: NullPointerException in plugin 'projectMgr' when listing TimeSheets (OFBIZ-12593)
e7af1f7 is described below

commit e7af1f77f4c38aada635689cb03ae0cfd685c405
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Sat Apr 2 11:37:32 2022 +0200

    Fixed: NullPointerException in plugin 'projectMgr' when listing TimeSheets (OFBIZ-12593)
    
    The empty string causes a NullPointerException, because in the WidgetWorker
    returns only an anchorElement  if the description of the hyperlink is not empty.
    
    Solution:  If the anchorElement is null, the line is simply not executed:
    
    Thanks: Tom Pietsch
---
 .../org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
index 9f33bee..b64d2ab 100644
--- a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
+++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
@@ -2915,7 +2915,9 @@ public final class MacroFormRenderer implements FormStringRenderer {
                 writer.append(hiddenFormElement.outerHtml());
                 final Element anchorElement = WidgetWorker.makeHiddenFormLinkAnchorElement(linkStyle,
                         encodedDescription, confirmation, modelFormField, request, context);
-                writer.append(anchorElement.outerHtml());
+                if (anchorElement != null) {
+                    writer.append(anchorElement.outerHtml());
+                }
             }
         } else {
             if ("layered-modal".equals(realLinkType)) {