You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/04/22 19:25:22 UTC
[GitHub] [commons-compress] arturobernalg commented on a diff in pull request #282: Avoid use C-style array declaration.
arturobernalg commented on code in PR #282:
URL: https://github.com/apache/commons-compress/pull/282#discussion_r856511665
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/BandSet.java:
##########
@@ -162,8 +162,8 @@ public long[] parseFlags(final String name, final InputStream in, final int coun
return parseFlags(name, in, new int[] {count}, (hasHi ? codec : null), codec)[0];
}
- public long[][] parseFlags(final String name, final InputStream in, final int counts[], final BHSDCodec codec,
- final boolean hasHi) throws IOException, Pack200Exception {
+ public long[][] parseFlags(final String name, final InputStream in, final int[] counts, final BHSDCodec codec,
+ final boolean hasHi) throws IOException, Pack200Exception {
Review Comment:
Done
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/BandSet.java:
##########
@@ -172,8 +172,8 @@ public long[] parseFlags(final String name, final InputStream in, final int coun
return parseFlags(name, in, new int[] {count}, hiCodec, loCodec)[0];
}
- public long[][] parseFlags(final String name, final InputStream in, final int counts[], final BHSDCodec hiCodec,
- final BHSDCodec loCodec) throws IOException, Pack200Exception {
+ public long[][] parseFlags(final String name, final InputStream in, final int[] counts, final BHSDCodec hiCodec,
+ final BHSDCodec loCodec) throws IOException, Pack200Exception {
Review Comment:
Done
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/BandSet.java:
##########
@@ -244,7 +244,7 @@ public String[] parseReferences(final String name, final InputStream in, final B
* @throws Pack200Exception if a problem occurs with an unexpected value or unsupported Codec
*/
public String[][] parseReferences(final String name, final InputStream in, final BHSDCodec codec,
- final int counts[], final String[] reference) throws IOException, Pack200Exception {
+ final int[] counts, final String[] reference) throws IOException, Pack200Exception {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org