You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/09/24 05:43:50 UTC
[GitHub] [james-project] vttranlina opened a new pull request #670: Remove GroupMembershipResolver and implement
vttranlina opened a new pull request #670:
URL: https://github.com/apache/james-project/pull/670
I propose to remove `GroupMembershipResolver`, `SimpleGroupMembershipResolver` and related
## Reason:
- interface GroupMembershipResolver has only one implement is SimpleGroupMembershipResolver
- As the author's comment at `SimpleGroupMembershipResolver`:
```
"There is no persistence. You will get only what you add
```
And nowhere call to `.addMemberShip` method => `.isMember` always return FALSE
Remove the exuberancy code to make it simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #670: Remove GroupMembershipResolver and implement
Posted by GitBox <gi...@apache.org>.
vttranlina commented on pull request #670:
URL: https://github.com/apache/james-project/pull/670#issuecomment-926405617
> But let's send the mail anyway ;-)
Yes, I sent it.
https://www.mail-archive.com/server-dev@james.apache.org/msg71095.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #670: Remove GroupMembershipResolver and implement
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #670:
URL: https://github.com/apache/james-project/pull/670#issuecomment-926391919
Please create an associated JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #670: Remove GroupMembershipResolver and implement
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #670:
URL: https://github.com/apache/james-project/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #670: Remove GroupMembershipResolver and implement
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #670:
URL: https://github.com/apache/james-project/pull/670#issuecomment-926397910
After looking at the changeset, I see that there is an interface and there is tests regarding group resolution in the face of a group.
Mailbox, for some people is a bit more than a sub-part object but an attempt to build a generic email storage reference.
As such I fear some might rely on group resolution in customized James instances or might use this part of the `mailbox-api` in there project.
I do support your initiaiive: ACL part of the code is complex. Yet I believe we should raise the topic on server-dev mailing list too... Can you send a mail on that very topic?
Regards,
Benoit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #670: Remove GroupMembershipResolver and implement
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #670:
URL: https://github.com/apache/james-project/pull/670#issuecomment-926403474
Reading the code, `MailboxACLResolver` is an interface. People having custom stuff would then be able to backport their changes behind it. THis makes your change less critical.
But let's send the mail anyway ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org