[GitHub] [netbeans] MKuettner commented on a change in pull request #2410: [NETBEANS-4857] prevent property change events during tree sync

[GitBox <gi...@apache.org>]

MKuettner commented on a change in pull request #2410:
URL: https://github.com/apache/netbeans/pull/2410#discussion_r500761445



##########
File path: platform/openide.explorer/src/org/openide/explorer/view/OutlineView.java
##########
@@ -876,6 +880,9 @@ final void synchronizeSelectedNodes(boolean scroll, Node... nodes) {
                 }
             }
         }
+        // [NETBEANS-4857]: re-activate property change events
+        outline.getSelectionModel().addListSelectionListener(managerListener);

Review comment:
       The ExplorerManager.PROP_SELECTED_NODES property change event is already fired before _synchronizeSelectedNodes(..)_ method is called. So i think there is no need for any more property change event within the synchronize method.
   
   But you are right setting _setValueIsAdjusting(true/false)_ is a much better solution. 
   I just tested this and it works fine for me.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists