You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Rakesh Sharma <ra...@expedia.com> on 2015/09/03 08:54:54 UTC
Review Request 38089: SQOOP-2335 : Hcatalog external table support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38089/
-----------------------------------------------------------
Review request for Sqoop and Venkat Ranganathan.
Repository: sqoop-trunk
Description
-------
Sqoop currently doesnt support creating external tables while importing data to hcatalog tables. This patch adds support to create hcatalog tables ehile importing data.
Diffs
-----
src/docs/user/hcatalog.txt 99ae4f5
src/java/org/apache/sqoop/SqoopOptions.java ace90fd
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24
src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec
src/java/org/apache/sqoop/tool/ImportTool.java 39af42c
src/java/org/apache/sqoop/util/HiveUtil.java PRE-CREATION
src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725
src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870
src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f
src/test/org/apache/sqoop/util/TestHiveUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/38089/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 38089: SQOOP-2335 : Hcatalog external table support
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38089/#review104652
-----------------------------------------------------------
Please run through checkstyle.
src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 1678)
<https://reviews.apache.org/r/38089/#comment162901>
Spaces - please fix whitespaces
src/java/org/apache/sqoop/tool/ImportTool.java (line 536)
<https://reviews.apache.org/r/38089/#comment162902>
Please fix the wording
Also can you please make sure this is tested with multiple mapper scenario. We may have to identify the hive version this will work correctly (we may be having issues with 0.11 and earlier) - So, may need to identify 0.13.1 as the new basic hive version.
- Venkat Ranganathan
On Sept. 23, 2015, 4:29 a.m., Rakesh Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38089/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 4:29 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop currently doesnt support creating external tables while importing data to hcatalog tables. This patch adds support to create hcatalog tables ehile importing data.
>
>
> Diffs
> -----
>
> src/docs/user/hcatalog.txt 99ae4f5
> src/java/org/apache/sqoop/SqoopOptions.java db92b30
> src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec
> src/java/org/apache/sqoop/tool/ImportTool.java 39af42c
> src/java/org/apache/sqoop/util/HiveUtil.java PRE-CREATION
> src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725
> src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870
> src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f
> src/test/org/apache/sqoop/util/TestHiveUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38089/diff/
>
>
> Testing
> -------
>
> YES
>
>
> Thanks,
>
> Rakesh Sharma
>
>
Re: Review Request 38089: SQOOP-2335 : Hcatalog external table support
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38089/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 11:29 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Rework on review comments
Repository: sqoop-trunk
Description
-------
Sqoop currently doesnt support creating external tables while importing data to hcatalog tables. This patch adds support to create hcatalog tables ehile importing data.
Diffs (updated)
-----
src/docs/user/hcatalog.txt 99ae4f5
src/java/org/apache/sqoop/SqoopOptions.java db92b30
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24
src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec
src/java/org/apache/sqoop/tool/ImportTool.java 39af42c
src/java/org/apache/sqoop/util/HiveUtil.java PRE-CREATION
src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725
src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870
src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f
src/test/org/apache/sqoop/util/TestHiveUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/38089/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 38089: SQOOP-2335 : Hcatalog external table support
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38089/#review99165
-----------------------------------------------------------
Thanks for submitting this. Please see couple of small issues
src/java/org/apache/sqoop/util/HiveUtil.java (line 39)
<https://reviews.apache.org/r/38089/#comment156069>
None of the following 4 constants are used
src/java/org/apache/sqoop/util/HiveUtil.java (line 61)
<https://reviews.apache.org/r/38089/#comment156070>
Not sure what the long name means - can we have simpler descriptive name - may be split into two and probably add a comment?
- Venkat Ranganathan
On Sept. 14, 2015, 11:51 p.m., Rakesh Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38089/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 11:51 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop currently doesnt support creating external tables while importing data to hcatalog tables. This patch adds support to create hcatalog tables ehile importing data.
>
>
> Diffs
> -----
>
> src/docs/user/hcatalog.txt 99ae4f5
> src/java/org/apache/sqoop/SqoopOptions.java ace90fd
> src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec
> src/java/org/apache/sqoop/tool/ImportTool.java 39af42c
> src/java/org/apache/sqoop/util/HiveUtil.java PRE-CREATION
> src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725
> src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870
> src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f
> src/test/org/apache/sqoop/util/TestHiveUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38089/diff/
>
>
> Testing
> -------
>
> YES
>
>
> Thanks,
>
> Rakesh Sharma
>
>
Re: Review Request 38089: SQOOP-2335 : Hcatalog external table support
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38089/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 6:51 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Making some changes in the test cases
Repository: sqoop-trunk
Description
-------
Sqoop currently doesnt support creating external tables while importing data to hcatalog tables. This patch adds support to create hcatalog tables ehile importing data.
Diffs (updated)
-----
src/docs/user/hcatalog.txt 99ae4f5
src/java/org/apache/sqoop/SqoopOptions.java ace90fd
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24
src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec
src/java/org/apache/sqoop/tool/ImportTool.java 39af42c
src/java/org/apache/sqoop/util/HiveUtil.java PRE-CREATION
src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725
src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870
src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f
src/test/org/apache/sqoop/util/TestHiveUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/38089/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma