[GitHub] [zeppelin] kkalyan commented on a diff in pull request #3496: [ZEPPELIN-4407] Add the ability to copy/paste result table

["kkalyan (via GitHub)" <gi...@apache.org>]

kkalyan commented on code in PR #3496:
URL: https://github.com/apache/zeppelin/pull/3496#discussion_r1117828333


##########
zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html:
##########
@@ -88,8 +88,10 @@
     <span class="sr-only">Toggle Dropdown</span>
   </button>
   <ul class="dropdown-menu" role="menu" style="min-width: 70px;">
-    <li ng-click="exportToDSV(',')"><a>CSV</a></li>
-    <li ng-click="exportToDSV('\t')"><a>TSV</a></li>
+    <li ng-click="copyToClipboard('\t')"><a>Copy as TSV</a></li>
+    <li ng-click="copyToClipboard(',')"><a>Copy as CSV</a></li>
+    <li ng-click="exportToDSV('\t')"><a>Download as TCV</a></li>

Review Comment:
   TSV



##########
zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html:
##########
@@ -88,8 +88,10 @@
     <span class="sr-only">Toggle Dropdown</span>
   </button>
   <ul class="dropdown-menu" role="menu" style="min-width: 70px;">
-    <li ng-click="exportToDSV(',')"><a>CSV</a></li>
-    <li ng-click="exportToDSV('\t')"><a>TSV</a></li>
+    <li ng-click="copyToClipboard('\t')"><a>Copy as TSV</a></li>
+    <li ng-click="copyToClipboard(',')"><a>Copy as CSV</a></li>
+    <li ng-click="exportToDSV('\t')"><a>Download as TCV</a></li>

Review Comment:
   TCV --> TSV



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org