[GitHub] [kafka] cmccabe commented on a diff in pull request #12928: KAFKA-14304 Add RPC changes, records, and config from KIP-866

[GitBox <gi...@apache.org>]

cmccabe commented on code in PR #12928:
URL: https://github.com/apache/kafka/pull/12928#discussion_r1036498788


##########
clients/src/main/resources/common/message/LeaderAndIsrRequest.json:
##########
@@ -29,11 +29,15 @@
   // Version 5 adds Topic ID and Type to the TopicStates, as described in KIP-516.
   //
   // Version 6 adds LeaderRecoveryState as described in KIP-704.
-  "validVersions": "0-6",
+  //
+  // Version 7 adds KRaft Controller ID field as part of KIP-866
+  "validVersions": "0-7",
   "flexibleVersions": "4+",
   "fields": [
     { "name": "ControllerId", "type": "int32", "versions": "0+", "entityType": "brokerId",
       "about": "The current controller ID." },
+    { "name": "KRaftControllerId", "type": "int32", "versions": "7+", "entityType": "brokerId",

Review Comment:
   Can we add a reference to KIP-866 here?
   
   Also, maybe good to set a default of -1 which will be used in the ZK case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org