You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Chesnay Schepler <ch...@apache.org> on 2018/05/16 10:40:19 UTC
[DISCUSS] GitBox
Hello,
during the discussion about how to better manage pull requests [1] the
topic of GitBox integration came up again.
This seems like a good opportunity to restart this discussion that we
had about a year ago [2].
* What is GitBox
Essentially, GitBox allow us to use GitHub features.
We can decide for ourselves which features we want enabled.
We could merge PRs directly on GitHub at the button of a click.
That said the merge functionality is fairly limited and would
require picture-perfect commits in the pull requests.
Commits can be squashed, but you cannot amend commits in any way, be
it fixing typos or changing the commit message. Realistically this
limits how much we can use this feature, and it may lead to a
decline in the quality of commit messages.
Labels can be useful for the management of PRs as (ready for review,
delayed for next release, waiting for changes). This is really what
I'm personally most interested in.
We've been using GitBox for flink-shaded for a while now and i
didn't run into any issue. AFAIK GitBox is also the default for new
projects.
* What this means for committers:
The apache git remote URL will change, which will require all
committers to update their git setup.
This also implies that we may have to update the website build scripts.
The new URL would (probably) be
/https://gitbox.apache.org/repos/asf/flink.git/.
To make use of GitHub features you have to link your GitHub and
Apache accounts. [3]
This also requires setting up two-factor authentication on GitHub.
Update the scm entry in the parent pom.xml.
* What this means for contributors:
Nothing should change for contributors. Small changes (like typos)
may be merged more quickly, if the commit message is appropriate, as
it could be done directly through GitHub.
[1]
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
[2]
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
[3] https://gitbox.apache.org/setup/
Re: [DISCUSS] GitBox
Posted by Piotr Nowojski <pi...@data-artisans.com>.
+1
> On 16 May 2018, at 14:24, Aljoscha Krettek <al...@apache.org> wrote:
>
> +1
>
> On Beam, we gradually enabled this, first for the website repo and then for the main repo and we didn't run into problems.
>
>> On 16. May 2018, at 12:45, Chesnay Schepler <ch...@apache.org> wrote:
>>
>> Forget an important feature: It would allow committers to close pull requests.
>>
>> On 16.05.2018 12:40, Chesnay Schepler wrote:
>>> Hello,
>>>
>>> during the discussion about how to better manage pull requests [1] the topic of GitBox integration came up again.
>>>
>>> This seems like a good opportunity to restart this discussion that we had about a year ago [2].
>>>
>>> * What is GitBox
>>>
>>> Essentially, GitBox allow us to use GitHub features.
>>> We can decide for ourselves which features we want enabled.
>>>
>>> We could merge PRs directly on GitHub at the button of a click.
>>> That said the merge functionality is fairly limited and would
>>> require picture-perfect commits in the pull requests.
>>> Commits can be squashed, but you cannot amend commits in any way, be
>>> it fixing typos or changing the commit message. Realistically this
>>> limits how much we can use this feature, and it may lead to a
>>> decline in the quality of commit messages.
>>>
>>> Labels can be useful for the management of PRs as (ready for review,
>>> delayed for next release, waiting for changes). This is really what
>>> I'm personally most interested in.
>>>
>>> We've been using GitBox for flink-shaded for a while now and i
>>> didn't run into any issue. AFAIK GitBox is also the default for new
>>> projects.
>>>
>>> * What this means for committers:
>>>
>>> The apache git remote URL will change, which will require all
>>> committers to update their git setup.
>>> This also implies that we may have to update the website build scripts.
>>> The new URL would (probably) be
>>> /https://gitbox.apache.org/repos/asf/flink.git/.
>>>
>>> To make use of GitHub features you have to link your GitHub and
>>> Apache accounts. [3]
>>> This also requires setting up two-factor authentication on GitHub.
>>>
>>> Update the scm entry in the parent pom.xml.
>>>
>>> * What this means for contributors:
>>>
>>> Nothing should change for contributors. Small changes (like typos)
>>> may be merged more quickly, if the commit message is appropriate, as
>>> it could be done directly through GitHub.
>>>
>>> [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
>>> [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
>>> [3] https://gitbox.apache.org/setup/
>>>
>>
>
Re: [DISCUSS] GitBox
Posted by Aljoscha Krettek <al...@apache.org>.
+1
On Beam, we gradually enabled this, first for the website repo and then for the main repo and we didn't run into problems.
> On 16. May 2018, at 12:45, Chesnay Schepler <ch...@apache.org> wrote:
>
> Forget an important feature: It would allow committers to close pull requests.
>
> On 16.05.2018 12:40, Chesnay Schepler wrote:
>> Hello,
>>
>> during the discussion about how to better manage pull requests [1] the topic of GitBox integration came up again.
>>
>> This seems like a good opportunity to restart this discussion that we had about a year ago [2].
>>
>> * What is GitBox
>>
>> Essentially, GitBox allow us to use GitHub features.
>> We can decide for ourselves which features we want enabled.
>>
>> We could merge PRs directly on GitHub at the button of a click.
>> That said the merge functionality is fairly limited and would
>> require picture-perfect commits in the pull requests.
>> Commits can be squashed, but you cannot amend commits in any way, be
>> it fixing typos or changing the commit message. Realistically this
>> limits how much we can use this feature, and it may lead to a
>> decline in the quality of commit messages.
>>
>> Labels can be useful for the management of PRs as (ready for review,
>> delayed for next release, waiting for changes). This is really what
>> I'm personally most interested in.
>>
>> We've been using GitBox for flink-shaded for a while now and i
>> didn't run into any issue. AFAIK GitBox is also the default for new
>> projects.
>>
>> * What this means for committers:
>>
>> The apache git remote URL will change, which will require all
>> committers to update their git setup.
>> This also implies that we may have to update the website build scripts.
>> The new URL would (probably) be
>> /https://gitbox.apache.org/repos/asf/flink.git/.
>>
>> To make use of GitHub features you have to link your GitHub and
>> Apache accounts. [3]
>> This also requires setting up two-factor authentication on GitHub.
>>
>> Update the scm entry in the parent pom.xml.
>>
>> * What this means for contributors:
>>
>> Nothing should change for contributors. Small changes (like typos)
>> may be merged more quickly, if the commit message is appropriate, as
>> it could be done directly through GitHub.
>>
>> [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
>> [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
>> [3] https://gitbox.apache.org/setup/
>>
>
Re: [DISCUSS] GitBox
Posted by Chesnay Schepler <ch...@apache.org>.
Forget an important feature: It would allow committers to close pull
requests.
On 16.05.2018 12:40, Chesnay Schepler wrote:
> Hello,
>
> during the discussion about how to better manage pull requests [1] the
> topic of GitBox integration came up again.
>
> This seems like a good opportunity to restart this discussion that we
> had about a year ago [2].
>
> * What is GitBox
>
> Essentially, GitBox allow us to use GitHub features.
> We can decide for ourselves which features we want enabled.
>
> We could merge PRs directly on GitHub at the button of a click.
> That said the merge functionality is fairly limited and would
> require picture-perfect commits in the pull requests.
> Commits can be squashed, but you cannot amend commits in any way, be
> it fixing typos or changing the commit message. Realistically this
> limits how much we can use this feature, and it may lead to a
> decline in the quality of commit messages.
>
> Labels can be useful for the management of PRs as (ready for review,
> delayed for next release, waiting for changes). This is really what
> I'm personally most interested in.
>
> We've been using GitBox for flink-shaded for a while now and i
> didn't run into any issue. AFAIK GitBox is also the default for new
> projects.
>
> * What this means for committers:
>
> The apache git remote URL will change, which will require all
> committers to update their git setup.
> This also implies that we may have to update the website build
> scripts.
> The new URL would (probably) be
> /https://gitbox.apache.org/repos/asf/flink.git/.
>
> To make use of GitHub features you have to link your GitHub and
> Apache accounts. [3]
> This also requires setting up two-factor authentication on GitHub.
>
> Update the scm entry in the parent pom.xml.
>
> * What this means for contributors:
>
> Nothing should change for contributors. Small changes (like typos)
> may be merged more quickly, if the commit message is appropriate, as
> it could be done directly through GitHub.
>
> [1]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
> [2]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
> [3] https://gitbox.apache.org/setup/
>
Re: [DISCUSS] GitBox
Posted by Kenneth Knowles <kl...@google.com.INVALID>.
Rong Rong, see my reply. It can be enabled by default. I think it may be
already.
Kenn
On Wed, May 16, 2018 at 4:24 PM Rong Rong <wa...@gmail.com> wrote:
> +1
>
> One question regarding "This however has to be enabled by the contributor,
> separately for each PR."
> can it be by default enable when creating PR?
>
> On Wed, May 16, 2018 at 2:08 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > +1
> > -------- Original message --------From: Shuyi Chen <su...@gmail.com>
> > Date: 5/16/18 1:12 PM (GMT-08:00) To: dev@flink.apache.org Subject:
> Re:
> > [DISCUSS] GitBox
> > +1 :) A lot of projects <https://gitbox.apache.org/repos/asf> are
> already
> > using it.
> >
> > On Wed, May 16, 2018 at 3:40 AM, Chesnay Schepler <ch...@apache.org>
> > wrote:
> >
> > > Hello,
> > >
> > > during the discussion about how to better manage pull requests [1] the
> > > topic of GitBox integration came up again.
> > >
> > > This seems like a good opportunity to restart this discussion that we
> had
> > > about a year ago [2].
> > >
> > > * What is GitBox
> > >
> > > Essentially, GitBox allow us to use GitHub features.
> > > We can decide for ourselves which features we want enabled.
> > >
> > > We could merge PRs directly on GitHub at the button of a click.
> > > That said the merge functionality is fairly limited and would
> > > require picture-perfect commits in the pull requests.
> > > Commits can be squashed, but you cannot amend commits in any way, be
> > > it fixing typos or changing the commit message. Realistically this
> > > limits how much we can use this feature, and it may lead to a
> > > decline in the quality of commit messages.
> > >
> > > Labels can be useful for the management of PRs as (ready for review,
> > > delayed for next release, waiting for changes). This is really what
> > > I'm personally most interested in.
> > >
> > > We've been using GitBox for flink-shaded for a while now and i
> > > didn't run into any issue. AFAIK GitBox is also the default for new
> > > projects.
> > >
> > > * What this means for committers:
> > >
> > > The apache git remote URL will change, which will require all
> > > committers to update their git setup.
> > > This also implies that we may have to update the website build
> > scripts.
> > > The new URL would (probably) be
> > > /https://gitbox.apache.org/repos/asf/flink.git/.
> > >
> > > To make use of GitHub features you have to link your GitHub and
> > > Apache accounts. [3]
> > > This also requires setting up two-factor authentication on GitHub.
> > >
> > > Update the scm entry in the parent pom.xml.
> > >
> > > * What this means for contributors:
> > >
> > > Nothing should change for contributors. Small changes (like typos)
> > > may be merged more quickly, if the commit message is appropriate, as
> > > it could be done directly through GitHub.
> > >
> > > [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> > > com/Closing-automatically-inactive-pull-requests-tt22248.html
> > > [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> > > com/DISCUSS-GitBox-td18027.html
> > > [3] https://gitbox.apache.org/setup/
> > >
> >
> >
> >
> > --
> > "So you have to trust that the dots will somehow connect in your future."
> >
>
Re: [DISCUSS] GitBox
Posted by Rong Rong <wa...@gmail.com>.
+1
One question regarding "This however has to be enabled by the contributor,
separately for each PR."
can it be by default enable when creating PR?
On Wed, May 16, 2018 at 2:08 PM, Ted Yu <yu...@gmail.com> wrote:
> +1
> -------- Original message --------From: Shuyi Chen <su...@gmail.com>
> Date: 5/16/18 1:12 PM (GMT-08:00) To: dev@flink.apache.org Subject: Re:
> [DISCUSS] GitBox
> +1 :) A lot of projects <https://gitbox.apache.org/repos/asf> are already
> using it.
>
> On Wed, May 16, 2018 at 3:40 AM, Chesnay Schepler <ch...@apache.org>
> wrote:
>
> > Hello,
> >
> > during the discussion about how to better manage pull requests [1] the
> > topic of GitBox integration came up again.
> >
> > This seems like a good opportunity to restart this discussion that we had
> > about a year ago [2].
> >
> > * What is GitBox
> >
> > Essentially, GitBox allow us to use GitHub features.
> > We can decide for ourselves which features we want enabled.
> >
> > We could merge PRs directly on GitHub at the button of a click.
> > That said the merge functionality is fairly limited and would
> > require picture-perfect commits in the pull requests.
> > Commits can be squashed, but you cannot amend commits in any way, be
> > it fixing typos or changing the commit message. Realistically this
> > limits how much we can use this feature, and it may lead to a
> > decline in the quality of commit messages.
> >
> > Labels can be useful for the management of PRs as (ready for review,
> > delayed for next release, waiting for changes). This is really what
> > I'm personally most interested in.
> >
> > We've been using GitBox for flink-shaded for a while now and i
> > didn't run into any issue. AFAIK GitBox is also the default for new
> > projects.
> >
> > * What this means for committers:
> >
> > The apache git remote URL will change, which will require all
> > committers to update their git setup.
> > This also implies that we may have to update the website build
> scripts.
> > The new URL would (probably) be
> > /https://gitbox.apache.org/repos/asf/flink.git/.
> >
> > To make use of GitHub features you have to link your GitHub and
> > Apache accounts. [3]
> > This also requires setting up two-factor authentication on GitHub.
> >
> > Update the scm entry in the parent pom.xml.
> >
> > * What this means for contributors:
> >
> > Nothing should change for contributors. Small changes (like typos)
> > may be merged more quickly, if the commit message is appropriate, as
> > it could be done directly through GitHub.
> >
> > [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> > com/Closing-automatically-inactive-pull-requests-tt22248.html
> > [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> > com/DISCUSS-GitBox-td18027.html
> > [3] https://gitbox.apache.org/setup/
> >
>
>
>
> --
> "So you have to trust that the dots will somehow connect in your future."
>
Re: [DISCUSS] GitBox
Posted by Ted Yu <yu...@gmail.com>.
+1
-------- Original message --------From: Shuyi Chen <su...@gmail.com> Date: 5/16/18 1:12 PM (GMT-08:00) To: dev@flink.apache.org Subject: Re: [DISCUSS] GitBox
+1 :) A lot of projects <https://gitbox.apache.org/repos/asf> are already
using it.
On Wed, May 16, 2018 at 3:40 AM, Chesnay Schepler <ch...@apache.org>
wrote:
> Hello,
>
> during the discussion about how to better manage pull requests [1] the
> topic of GitBox integration came up again.
>
> This seems like a good opportunity to restart this discussion that we had
> about a year ago [2].
>
> * What is GitBox
>
> Essentially, GitBox allow us to use GitHub features.
> We can decide for ourselves which features we want enabled.
>
> We could merge PRs directly on GitHub at the button of a click.
> That said the merge functionality is fairly limited and would
> require picture-perfect commits in the pull requests.
> Commits can be squashed, but you cannot amend commits in any way, be
> it fixing typos or changing the commit message. Realistically this
> limits how much we can use this feature, and it may lead to a
> decline in the quality of commit messages.
>
> Labels can be useful for the management of PRs as (ready for review,
> delayed for next release, waiting for changes). This is really what
> I'm personally most interested in.
>
> We've been using GitBox for flink-shaded for a while now and i
> didn't run into any issue. AFAIK GitBox is also the default for new
> projects.
>
> * What this means for committers:
>
> The apache git remote URL will change, which will require all
> committers to update their git setup.
> This also implies that we may have to update the website build scripts.
> The new URL would (probably) be
> /https://gitbox.apache.org/repos/asf/flink.git/.
>
> To make use of GitHub features you have to link your GitHub and
> Apache accounts. [3]
> This also requires setting up two-factor authentication on GitHub.
>
> Update the scm entry in the parent pom.xml.
>
> * What this means for contributors:
>
> Nothing should change for contributors. Small changes (like typos)
> may be merged more quickly, if the commit message is appropriate, as
> it could be done directly through GitHub.
>
> [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> com/Closing-automatically-inactive-pull-requests-tt22248.html
> [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> com/DISCUSS-GitBox-td18027.html
> [3] https://gitbox.apache.org/setup/
>
--
"So you have to trust that the dots will somehow connect in your future."
Re: [DISCUSS] GitBox
Posted by Shuyi Chen <su...@gmail.com>.
+1 :) A lot of projects <https://gitbox.apache.org/repos/asf> are already
using it.
On Wed, May 16, 2018 at 3:40 AM, Chesnay Schepler <ch...@apache.org>
wrote:
> Hello,
>
> during the discussion about how to better manage pull requests [1] the
> topic of GitBox integration came up again.
>
> This seems like a good opportunity to restart this discussion that we had
> about a year ago [2].
>
> * What is GitBox
>
> Essentially, GitBox allow us to use GitHub features.
> We can decide for ourselves which features we want enabled.
>
> We could merge PRs directly on GitHub at the button of a click.
> That said the merge functionality is fairly limited and would
> require picture-perfect commits in the pull requests.
> Commits can be squashed, but you cannot amend commits in any way, be
> it fixing typos or changing the commit message. Realistically this
> limits how much we can use this feature, and it may lead to a
> decline in the quality of commit messages.
>
> Labels can be useful for the management of PRs as (ready for review,
> delayed for next release, waiting for changes). This is really what
> I'm personally most interested in.
>
> We've been using GitBox for flink-shaded for a while now and i
> didn't run into any issue. AFAIK GitBox is also the default for new
> projects.
>
> * What this means for committers:
>
> The apache git remote URL will change, which will require all
> committers to update their git setup.
> This also implies that we may have to update the website build scripts.
> The new URL would (probably) be
> /https://gitbox.apache.org/repos/asf/flink.git/.
>
> To make use of GitHub features you have to link your GitHub and
> Apache accounts. [3]
> This also requires setting up two-factor authentication on GitHub.
>
> Update the scm entry in the parent pom.xml.
>
> * What this means for contributors:
>
> Nothing should change for contributors. Small changes (like typos)
> may be merged more quickly, if the commit message is appropriate, as
> it could be done directly through GitHub.
>
> [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> com/Closing-automatically-inactive-pull-requests-tt22248.html
> [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.
> com/DISCUSS-GitBox-td18027.html
> [3] https://gitbox.apache.org/setup/
>
--
"So you have to trust that the dots will somehow connect in your future."
Re: [DISCUSS] GitBox
Posted by Timo Walther <tw...@apache.org>.
+1 for using Gitbox
Timo
Am 16.05.18 um 17:43 schrieb Kenneth Knowles:
> Actually, GitHub has a feature so you do not require picture-perfect
> commits:
> https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
>
> If the owner of the PR checks the box, it will give committers write access
> to their branch (on their fork). A nice bonus is you can make the changes
> and then continue the review, too.
>
> Kenn
>
> On Wed, May 16, 2018 at 8:31 AM Stefan Richter <s....@data-artisans.com>
> wrote:
>
>> +1
>>
>>> Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
>>>
>>> Hello,
>>>
>>> during the discussion about how to better manage pull requests [1] the
>> topic of GitBox integration came up again.
>>> This seems like a good opportunity to restart this discussion that we
>> had about a year ago [2].
>>> * What is GitBox
>>>
>>> Essentially, GitBox allow us to use GitHub features.
>>> We can decide for ourselves which features we want enabled.
>>>
>>> We could merge PRs directly on GitHub at the button of a click.
>>> That said the merge functionality is fairly limited and would
>>> require picture-perfect commits in the pull requests.
>>> Commits can be squashed, but you cannot amend commits in any way, be
>>> it fixing typos or changing the commit message. Realistically this
>>> limits how much we can use this feature, and it may lead to a
>>> decline in the quality of commit messages.
>>>
>>> Labels can be useful for the management of PRs as (ready for review,
>>> delayed for next release, waiting for changes). This is really what
>>> I'm personally most interested in.
>>>
>>> We've been using GitBox for flink-shaded for a while now and i
>>> didn't run into any issue. AFAIK GitBox is also the default for new
>>> projects.
>>>
>>> * What this means for committers:
>>>
>>> The apache git remote URL will change, which will require all
>>> committers to update their git setup.
>>> This also implies that we may have to update the website build scripts.
>>> The new URL would (probably) be
>>> /https://gitbox.apache.org/repos/asf/flink.git/.
>>>
>>> To make use of GitHub features you have to link your GitHub and
>>> Apache accounts. [3]
>>> This also requires setting up two-factor authentication on GitHub.
>>>
>>> Update the scm entry in the parent pom.xml.
>>>
>>> * What this means for contributors:
>>>
>>> Nothing should change for contributors. Small changes (like typos)
>>> may be merged more quickly, if the commit message is appropriate, as
>>> it could be done directly through GitHub.
>>>
>>> [1]
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
>>> [2]
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
>>> [3] https://gitbox.apache.org/setup/
>>
Re: [DISCUSS] GitBox
Posted by Chesnay Schepler <ch...@apache.org>.
I couldn't find any such setting in one of my repos :(
On 16.05.2018 21:03, Kenneth Knowles wrote:
> When I open a pull request to Beam, it is on by default. I have just run an
> experiment to see if it is remembering the last option I checked and it is
> not. Even after I disable it for one pull request, the next one has it
> checked again. So it may be a repository-level setting that you can set up.
>
> Kenn
>
> On Wed, May 16, 2018 at 11:19 AM Chesnay Schepler <ch...@apache.org>
> wrote:
>
>> This however has to be enabled by the contributor, separately for each PR.
>> We'll see how often we get the opportunity to use it.
>>
>> On 16.05.2018 17:43, Kenneth Knowles wrote:
>>> Actually, GitHub has a feature so you do not require picture-perfect
>>> commits:
>>>
>> https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
>>> If the owner of the PR checks the box, it will give committers write
>> access
>>> to their branch (on their fork). A nice bonus is you can make the changes
>>> and then continue the review, too.
>>>
>>> Kenn
>>>
>>> On Wed, May 16, 2018 at 8:31 AM Stefan Richter <
>> s.richter@data-artisans.com>
>>> wrote:
>>>
>>>> +1
>>>>
>>>>> Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
>>>>>
>>>>> Hello,
>>>>>
>>>>> during the discussion about how to better manage pull requests [1] the
>>>> topic of GitBox integration came up again.
>>>>> This seems like a good opportunity to restart this discussion that we
>>>> had about a year ago [2].
>>>>> * What is GitBox
>>>>>
>>>>> Essentially, GitBox allow us to use GitHub features.
>>>>> We can decide for ourselves which features we want enabled.
>>>>>
>>>>> We could merge PRs directly on GitHub at the button of a click.
>>>>> That said the merge functionality is fairly limited and would
>>>>> require picture-perfect commits in the pull requests.
>>>>> Commits can be squashed, but you cannot amend commits in any way, be
>>>>> it fixing typos or changing the commit message. Realistically this
>>>>> limits how much we can use this feature, and it may lead to a
>>>>> decline in the quality of commit messages.
>>>>>
>>>>> Labels can be useful for the management of PRs as (ready for review,
>>>>> delayed for next release, waiting for changes). This is really what
>>>>> I'm personally most interested in.
>>>>>
>>>>> We've been using GitBox for flink-shaded for a while now and i
>>>>> didn't run into any issue. AFAIK GitBox is also the default for new
>>>>> projects.
>>>>>
>>>>> * What this means for committers:
>>>>>
>>>>> The apache git remote URL will change, which will require all
>>>>> committers to update their git setup.
>>>>> This also implies that we may have to update the website build
>> scripts.
>>>>> The new URL would (probably) be
>>>>> /https://gitbox.apache.org/repos/asf/flink.git/.
>>>>>
>>>>> To make use of GitHub features you have to link your GitHub and
>>>>> Apache accounts. [3]
>>>>> This also requires setting up two-factor authentication on GitHub.
>>>>>
>>>>> Update the scm entry in the parent pom.xml.
>>>>>
>>>>> * What this means for contributors:
>>>>>
>>>>> Nothing should change for contributors. Small changes (like typos)
>>>>> may be merged more quickly, if the commit message is appropriate, as
>>>>> it could be done directly through GitHub.
>>>>>
>>>>> [1]
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
>>>>> [2]
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
>>>>> [3] https://gitbox.apache.org/setup/
>>
Re: [DISCUSS] GitBox
Posted by Fabian Hueske <fh...@gmail.com>.
+1
Kenneth Knowles <kl...@google.com.invalid> schrieb am Mi., 16. Mai 2018,
21:04:
> When I open a pull request to Beam, it is on by default. I have just run an
> experiment to see if it is remembering the last option I checked and it is
> not. Even after I disable it for one pull request, the next one has it
> checked again. So it may be a repository-level setting that you can set up.
>
> Kenn
>
> On Wed, May 16, 2018 at 11:19 AM Chesnay Schepler <ch...@apache.org>
> wrote:
>
> > This however has to be enabled by the contributor, separately for each
> PR.
> > We'll see how often we get the opportunity to use it.
> >
> > On 16.05.2018 17:43, Kenneth Knowles wrote:
> > > Actually, GitHub has a feature so you do not require picture-perfect
> > > commits:
> > >
> >
> https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
> > >
> > > If the owner of the PR checks the box, it will give committers write
> > access
> > > to their branch (on their fork). A nice bonus is you can make the
> changes
> > > and then continue the review, too.
> > >
> > > Kenn
> > >
> > > On Wed, May 16, 2018 at 8:31 AM Stefan Richter <
> > s.richter@data-artisans.com>
> > > wrote:
> > >
> > >> +1
> > >>
> > >>> Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <chesnay@apache.org
> >:
> > >>>
> > >>> Hello,
> > >>>
> > >>> during the discussion about how to better manage pull requests [1]
> the
> > >> topic of GitBox integration came up again.
> > >>> This seems like a good opportunity to restart this discussion that we
> > >> had about a year ago [2].
> > >>> * What is GitBox
> > >>>
> > >>> Essentially, GitBox allow us to use GitHub features.
> > >>> We can decide for ourselves which features we want enabled.
> > >>>
> > >>> We could merge PRs directly on GitHub at the button of a click.
> > >>> That said the merge functionality is fairly limited and would
> > >>> require picture-perfect commits in the pull requests.
> > >>> Commits can be squashed, but you cannot amend commits in any way,
> be
> > >>> it fixing typos or changing the commit message. Realistically this
> > >>> limits how much we can use this feature, and it may lead to a
> > >>> decline in the quality of commit messages.
> > >>>
> > >>> Labels can be useful for the management of PRs as (ready for
> review,
> > >>> delayed for next release, waiting for changes). This is really
> what
> > >>> I'm personally most interested in.
> > >>>
> > >>> We've been using GitBox for flink-shaded for a while now and i
> > >>> didn't run into any issue. AFAIK GitBox is also the default for
> new
> > >>> projects.
> > >>>
> > >>> * What this means for committers:
> > >>>
> > >>> The apache git remote URL will change, which will require all
> > >>> committers to update their git setup.
> > >>> This also implies that we may have to update the website build
> > scripts.
> > >>> The new URL would (probably) be
> > >>> /https://gitbox.apache.org/repos/asf/flink.git/.
> > >>>
> > >>> To make use of GitHub features you have to link your GitHub and
> > >>> Apache accounts. [3]
> > >>> This also requires setting up two-factor authentication on GitHub.
> > >>>
> > >>> Update the scm entry in the parent pom.xml.
> > >>>
> > >>> * What this means for contributors:
> > >>>
> > >>> Nothing should change for contributors. Small changes (like typos)
> > >>> may be merged more quickly, if the commit message is appropriate,
> as
> > >>> it could be done directly through GitHub.
> > >>>
> > >>> [1]
> > >>
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
> > >>> [2]
> > >>
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
> > >>> [3] https://gitbox.apache.org/setup/
> > >>
> >
> >
>
Re: [DISCUSS] GitBox
Posted by Kenneth Knowles <kl...@google.com.INVALID>.
When I open a pull request to Beam, it is on by default. I have just run an
experiment to see if it is remembering the last option I checked and it is
not. Even after I disable it for one pull request, the next one has it
checked again. So it may be a repository-level setting that you can set up.
Kenn
On Wed, May 16, 2018 at 11:19 AM Chesnay Schepler <ch...@apache.org>
wrote:
> This however has to be enabled by the contributor, separately for each PR.
> We'll see how often we get the opportunity to use it.
>
> On 16.05.2018 17:43, Kenneth Knowles wrote:
> > Actually, GitHub has a feature so you do not require picture-perfect
> > commits:
> >
> https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
> >
> > If the owner of the PR checks the box, it will give committers write
> access
> > to their branch (on their fork). A nice bonus is you can make the changes
> > and then continue the review, too.
> >
> > Kenn
> >
> > On Wed, May 16, 2018 at 8:31 AM Stefan Richter <
> s.richter@data-artisans.com>
> > wrote:
> >
> >> +1
> >>
> >>> Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
> >>>
> >>> Hello,
> >>>
> >>> during the discussion about how to better manage pull requests [1] the
> >> topic of GitBox integration came up again.
> >>> This seems like a good opportunity to restart this discussion that we
> >> had about a year ago [2].
> >>> * What is GitBox
> >>>
> >>> Essentially, GitBox allow us to use GitHub features.
> >>> We can decide for ourselves which features we want enabled.
> >>>
> >>> We could merge PRs directly on GitHub at the button of a click.
> >>> That said the merge functionality is fairly limited and would
> >>> require picture-perfect commits in the pull requests.
> >>> Commits can be squashed, but you cannot amend commits in any way, be
> >>> it fixing typos or changing the commit message. Realistically this
> >>> limits how much we can use this feature, and it may lead to a
> >>> decline in the quality of commit messages.
> >>>
> >>> Labels can be useful for the management of PRs as (ready for review,
> >>> delayed for next release, waiting for changes). This is really what
> >>> I'm personally most interested in.
> >>>
> >>> We've been using GitBox for flink-shaded for a while now and i
> >>> didn't run into any issue. AFAIK GitBox is also the default for new
> >>> projects.
> >>>
> >>> * What this means for committers:
> >>>
> >>> The apache git remote URL will change, which will require all
> >>> committers to update their git setup.
> >>> This also implies that we may have to update the website build
> scripts.
> >>> The new URL would (probably) be
> >>> /https://gitbox.apache.org/repos/asf/flink.git/.
> >>>
> >>> To make use of GitHub features you have to link your GitHub and
> >>> Apache accounts. [3]
> >>> This also requires setting up two-factor authentication on GitHub.
> >>>
> >>> Update the scm entry in the parent pom.xml.
> >>>
> >>> * What this means for contributors:
> >>>
> >>> Nothing should change for contributors. Small changes (like typos)
> >>> may be merged more quickly, if the commit message is appropriate, as
> >>> it could be done directly through GitHub.
> >>>
> >>> [1]
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
> >>> [2]
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
> >>> [3] https://gitbox.apache.org/setup/
> >>
>
>
Re: [DISCUSS] GitBox
Posted by Chesnay Schepler <ch...@apache.org>.
This however has to be enabled by the contributor, separately for each PR.
We'll see how often we get the opportunity to use it.
On 16.05.2018 17:43, Kenneth Knowles wrote:
> Actually, GitHub has a feature so you do not require picture-perfect
> commits:
> https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
>
> If the owner of the PR checks the box, it will give committers write access
> to their branch (on their fork). A nice bonus is you can make the changes
> and then continue the review, too.
>
> Kenn
>
> On Wed, May 16, 2018 at 8:31 AM Stefan Richter <s....@data-artisans.com>
> wrote:
>
>> +1
>>
>>> Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
>>>
>>> Hello,
>>>
>>> during the discussion about how to better manage pull requests [1] the
>> topic of GitBox integration came up again.
>>> This seems like a good opportunity to restart this discussion that we
>> had about a year ago [2].
>>> * What is GitBox
>>>
>>> Essentially, GitBox allow us to use GitHub features.
>>> We can decide for ourselves which features we want enabled.
>>>
>>> We could merge PRs directly on GitHub at the button of a click.
>>> That said the merge functionality is fairly limited and would
>>> require picture-perfect commits in the pull requests.
>>> Commits can be squashed, but you cannot amend commits in any way, be
>>> it fixing typos or changing the commit message. Realistically this
>>> limits how much we can use this feature, and it may lead to a
>>> decline in the quality of commit messages.
>>>
>>> Labels can be useful for the management of PRs as (ready for review,
>>> delayed for next release, waiting for changes). This is really what
>>> I'm personally most interested in.
>>>
>>> We've been using GitBox for flink-shaded for a while now and i
>>> didn't run into any issue. AFAIK GitBox is also the default for new
>>> projects.
>>>
>>> * What this means for committers:
>>>
>>> The apache git remote URL will change, which will require all
>>> committers to update their git setup.
>>> This also implies that we may have to update the website build scripts.
>>> The new URL would (probably) be
>>> /https://gitbox.apache.org/repos/asf/flink.git/.
>>>
>>> To make use of GitHub features you have to link your GitHub and
>>> Apache accounts. [3]
>>> This also requires setting up two-factor authentication on GitHub.
>>>
>>> Update the scm entry in the parent pom.xml.
>>>
>>> * What this means for contributors:
>>>
>>> Nothing should change for contributors. Small changes (like typos)
>>> may be merged more quickly, if the commit message is appropriate, as
>>> it could be done directly through GitHub.
>>>
>>> [1]
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
>>> [2]
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
>>> [3] https://gitbox.apache.org/setup/
>>
Re: [DISCUSS] GitBox
Posted by Kenneth Knowles <kl...@google.com.INVALID>.
Actually, GitHub has a feature so you do not require picture-perfect
commits:
https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
If the owner of the PR checks the box, it will give committers write access
to their branch (on their fork). A nice bonus is you can make the changes
and then continue the review, too.
Kenn
On Wed, May 16, 2018 at 8:31 AM Stefan Richter <s....@data-artisans.com>
wrote:
> +1
>
> > Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
> >
> > Hello,
> >
> > during the discussion about how to better manage pull requests [1] the
> topic of GitBox integration came up again.
> >
> > This seems like a good opportunity to restart this discussion that we
> had about a year ago [2].
> >
> > * What is GitBox
> >
> > Essentially, GitBox allow us to use GitHub features.
> > We can decide for ourselves which features we want enabled.
> >
> > We could merge PRs directly on GitHub at the button of a click.
> > That said the merge functionality is fairly limited and would
> > require picture-perfect commits in the pull requests.
> > Commits can be squashed, but you cannot amend commits in any way, be
> > it fixing typos or changing the commit message. Realistically this
> > limits how much we can use this feature, and it may lead to a
> > decline in the quality of commit messages.
> >
> > Labels can be useful for the management of PRs as (ready for review,
> > delayed for next release, waiting for changes). This is really what
> > I'm personally most interested in.
> >
> > We've been using GitBox for flink-shaded for a while now and i
> > didn't run into any issue. AFAIK GitBox is also the default for new
> > projects.
> >
> > * What this means for committers:
> >
> > The apache git remote URL will change, which will require all
> > committers to update their git setup.
> > This also implies that we may have to update the website build scripts.
> > The new URL would (probably) be
> > /https://gitbox.apache.org/repos/asf/flink.git/.
> >
> > To make use of GitHub features you have to link your GitHub and
> > Apache accounts. [3]
> > This also requires setting up two-factor authentication on GitHub.
> >
> > Update the scm entry in the parent pom.xml.
> >
> > * What this means for contributors:
> >
> > Nothing should change for contributors. Small changes (like typos)
> > may be merged more quickly, if the commit message is appropriate, as
> > it could be done directly through GitHub.
> >
> > [1]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
> > [2]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
> > [3] https://gitbox.apache.org/setup/
>
>
Re: [DISCUSS] GitBox
Posted by Suneel Marthi <sm...@apache.org>.
+1
On Wed, May 16, 2018 at 2:09 PM, Thomas Weise <th...@apache.org> wrote:
> +1
>
>
> On Wed, May 16, 2018 at 8:31 AM, Stefan Richter <
> s.richter@data-artisans.com
> > wrote:
>
> > +1
> >
> > > Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
> > >
> > > Hello,
> > >
> > > during the discussion about how to better manage pull requests [1] the
> > topic of GitBox integration came up again.
> > >
> > > This seems like a good opportunity to restart this discussion that we
> > had about a year ago [2].
> > >
> > > * What is GitBox
> > >
> > > Essentially, GitBox allow us to use GitHub features.
> > > We can decide for ourselves which features we want enabled.
> > >
> > > We could merge PRs directly on GitHub at the button of a click.
> > > That said the merge functionality is fairly limited and would
> > > require picture-perfect commits in the pull requests.
> > > Commits can be squashed, but you cannot amend commits in any way, be
> > > it fixing typos or changing the commit message. Realistically this
> > > limits how much we can use this feature, and it may lead to a
> > > decline in the quality of commit messages.
> > >
> > > Labels can be useful for the management of PRs as (ready for review,
> > > delayed for next release, waiting for changes). This is really what
> > > I'm personally most interested in.
> > >
> > > We've been using GitBox for flink-shaded for a while now and i
> > > didn't run into any issue. AFAIK GitBox is also the default for new
> > > projects.
> > >
> > > * What this means for committers:
> > >
> > > The apache git remote URL will change, which will require all
> > > committers to update their git setup.
> > > This also implies that we may have to update the website build
> scripts.
> > > The new URL would (probably) be
> > > /https://gitbox.apache.org/repos/asf/flink.git/.
> > >
> > > To make use of GitHub features you have to link your GitHub and
> > > Apache accounts. [3]
> > > This also requires setting up two-factor authentication on GitHub.
> > >
> > > Update the scm entry in the parent pom.xml.
> > >
> > > * What this means for contributors:
> > >
> > > Nothing should change for contributors. Small changes (like typos)
> > > may be merged more quickly, if the commit message is appropriate, as
> > > it could be done directly through GitHub.
> > >
> > > [1] http://apache-flink-mailing-list-archive.1008284.n3.
> > nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
> > > [2] http://apache-flink-mailing-list-archive.1008284.n3.
> > nabble.com/DISCUSS-GitBox-td18027.html
> > > [3] https://gitbox.apache.org/setup/
> >
> >
>
Re: [DISCUSS] GitBox
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1
Regards
JB
Le 16 mai 2018 à 20:09, à 20:09, Thomas Weise <th...@apache.org> a écrit:
>+1
>
>
>On Wed, May 16, 2018 at 8:31 AM, Stefan Richter
><s.richter@data-artisans.com
>> wrote:
>
>> +1
>>
>> > Am 16.05.2018 um 12:40 schrieb Chesnay Schepler
><ch...@apache.org>:
>> >
>> > Hello,
>> >
>> > during the discussion about how to better manage pull requests [1]
>the
>> topic of GitBox integration came up again.
>> >
>> > This seems like a good opportunity to restart this discussion that
>we
>> had about a year ago [2].
>> >
>> > * What is GitBox
>> >
>> > Essentially, GitBox allow us to use GitHub features.
>> > We can decide for ourselves which features we want enabled.
>> >
>> > We could merge PRs directly on GitHub at the button of a click.
>> > That said the merge functionality is fairly limited and would
>> > require picture-perfect commits in the pull requests.
>> > Commits can be squashed, but you cannot amend commits in any way,
>be
>> > it fixing typos or changing the commit message. Realistically
>this
>> > limits how much we can use this feature, and it may lead to a
>> > decline in the quality of commit messages.
>> >
>> > Labels can be useful for the management of PRs as (ready for
>review,
>> > delayed for next release, waiting for changes). This is really
>what
>> > I'm personally most interested in.
>> >
>> > We've been using GitBox for flink-shaded for a while now and i
>> > didn't run into any issue. AFAIK GitBox is also the default for
>new
>> > projects.
>> >
>> > * What this means for committers:
>> >
>> > The apache git remote URL will change, which will require all
>> > committers to update their git setup.
>> > This also implies that we may have to update the website build
>scripts.
>> > The new URL would (probably) be
>> > /https://gitbox.apache.org/repos/asf/flink.git/.
>> >
>> > To make use of GitHub features you have to link your GitHub and
>> > Apache accounts. [3]
>> > This also requires setting up two-factor authentication on
>GitHub.
>> >
>> > Update the scm entry in the parent pom.xml.
>> >
>> > * What this means for contributors:
>> >
>> > Nothing should change for contributors. Small changes (like
>typos)
>> > may be merged more quickly, if the commit message is appropriate,
>as
>> > it could be done directly through GitHub.
>> >
>> > [1] http://apache-flink-mailing-list-archive.1008284.n3.
>> nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
>> > [2] http://apache-flink-mailing-list-archive.1008284.n3.
>> nabble.com/DISCUSS-GitBox-td18027.html
>> > [3] https://gitbox.apache.org/setup/
>>
>>
Re: [DISCUSS] GitBox
Posted by Thomas Weise <th...@apache.org>.
+1
On Wed, May 16, 2018 at 8:31 AM, Stefan Richter <s.richter@data-artisans.com
> wrote:
> +1
>
> > Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
> >
> > Hello,
> >
> > during the discussion about how to better manage pull requests [1] the
> topic of GitBox integration came up again.
> >
> > This seems like a good opportunity to restart this discussion that we
> had about a year ago [2].
> >
> > * What is GitBox
> >
> > Essentially, GitBox allow us to use GitHub features.
> > We can decide for ourselves which features we want enabled.
> >
> > We could merge PRs directly on GitHub at the button of a click.
> > That said the merge functionality is fairly limited and would
> > require picture-perfect commits in the pull requests.
> > Commits can be squashed, but you cannot amend commits in any way, be
> > it fixing typos or changing the commit message. Realistically this
> > limits how much we can use this feature, and it may lead to a
> > decline in the quality of commit messages.
> >
> > Labels can be useful for the management of PRs as (ready for review,
> > delayed for next release, waiting for changes). This is really what
> > I'm personally most interested in.
> >
> > We've been using GitBox for flink-shaded for a while now and i
> > didn't run into any issue. AFAIK GitBox is also the default for new
> > projects.
> >
> > * What this means for committers:
> >
> > The apache git remote URL will change, which will require all
> > committers to update their git setup.
> > This also implies that we may have to update the website build scripts.
> > The new URL would (probably) be
> > /https://gitbox.apache.org/repos/asf/flink.git/.
> >
> > To make use of GitHub features you have to link your GitHub and
> > Apache accounts. [3]
> > This also requires setting up two-factor authentication on GitHub.
> >
> > Update the scm entry in the parent pom.xml.
> >
> > * What this means for contributors:
> >
> > Nothing should change for contributors. Small changes (like typos)
> > may be merged more quickly, if the commit message is appropriate, as
> > it could be done directly through GitHub.
> >
> > [1] http://apache-flink-mailing-list-archive.1008284.n3.
> nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
> > [2] http://apache-flink-mailing-list-archive.1008284.n3.
> nabble.com/DISCUSS-GitBox-td18027.html
> > [3] https://gitbox.apache.org/setup/
>
>
Re: [DISCUSS] GitBox
Posted by Stefan Richter <s....@data-artisans.com>.
+1
> Am 16.05.2018 um 12:40 schrieb Chesnay Schepler <ch...@apache.org>:
>
> Hello,
>
> during the discussion about how to better manage pull requests [1] the topic of GitBox integration came up again.
>
> This seems like a good opportunity to restart this discussion that we had about a year ago [2].
>
> * What is GitBox
>
> Essentially, GitBox allow us to use GitHub features.
> We can decide for ourselves which features we want enabled.
>
> We could merge PRs directly on GitHub at the button of a click.
> That said the merge functionality is fairly limited and would
> require picture-perfect commits in the pull requests.
> Commits can be squashed, but you cannot amend commits in any way, be
> it fixing typos or changing the commit message. Realistically this
> limits how much we can use this feature, and it may lead to a
> decline in the quality of commit messages.
>
> Labels can be useful for the management of PRs as (ready for review,
> delayed for next release, waiting for changes). This is really what
> I'm personally most interested in.
>
> We've been using GitBox for flink-shaded for a while now and i
> didn't run into any issue. AFAIK GitBox is also the default for new
> projects.
>
> * What this means for committers:
>
> The apache git remote URL will change, which will require all
> committers to update their git setup.
> This also implies that we may have to update the website build scripts.
> The new URL would (probably) be
> /https://gitbox.apache.org/repos/asf/flink.git/.
>
> To make use of GitHub features you have to link your GitHub and
> Apache accounts. [3]
> This also requires setting up two-factor authentication on GitHub.
>
> Update the scm entry in the parent pom.xml.
>
> * What this means for contributors:
>
> Nothing should change for contributors. Small changes (like typos)
> may be merged more quickly, if the commit message is appropriate, as
> it could be done directly through GitHub.
>
> [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Closing-automatically-inactive-pull-requests-tt22248.html
> [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-GitBox-td18027.html
> [3] https://gitbox.apache.org/setup/