Re: [PR] fix(#2491): Keep selected nodes when updating an existing adapter

["yanfeng1992 (via GitHub)" <gi...@apache.org>]

yanfeng1992 commented on code in PR #2492:
URL: https://github.com/apache/streampipes/pull/2492#discussion_r1505228080


##########
streampipes-connect-shared/src/main/java/org/apache/streampipes/connect/shared/preprocessing/convert/ToTransformedSchemaConverter.java:
##########
@@ -102,13 +106,15 @@ public void visit(RemoveDuplicatesTransformationRuleDescription rule) {
 
   @Override
   public void visit(AddTimestampRuleDescription rule) {
-    this.properties.add(EpProperties.timestampProperty(rule.getRuntimeKey()));
+    var timestampProperty = EpProperties.timestampProperty(rule.getRuntimeKey());
+    timestampProperty.setElementId(TIMESTAMP_ID_PREFIX + UUIDGenerator.generateUuid());

Review Comment:
   I also found the same problem, happy to see the fix
   I have a suggestion. The uuid here in ui is not replaced -, and the front-end and back-end processing is not consistent.  @dominikriemer 
   
   https://github.com/apache/streampipes/blob/7000686a2036512221f85a2723ae811812bb6cd1/ui/src/app/connect/components/adapter-configuration/schema-editor/event-schema/event-schema.component.ts#L247
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org