You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2016/12/30 07:01:07 UTC
[GitHub] zeppelin pull request #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (gru...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1824
[ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
### What is this PR for?
Replaced `grunt-contrib-clean` to [rimraf](https://github.com/isaacs/rimraf)
- to remove `Gruntfile.js`
- to have npm managed scripts in `package.json` while running `rm -rf` in multiple platforms including windows
- Also, fixed invalid `prestart` npm command to `predev`
This PR related to
- https://github.com/apache/zeppelin/pull/1812 (Using yarn)
- https://github.com/apache/zeppelin/pull/1818 (Removing jscs)
### What type of PR is it?
[Improvement]
### Todos
Done at once
### What is the Jira issue?
[ZEPPELIN-1850](https://issues.apache.org/jira/browse/ZEPPELIN-1850)
### How should this be tested?
- `npm run test`, `npm run build`, `npm run dev` should work
### Screenshots (if appropriate)
None
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1850/remove-grunt-clean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1824
----
commit 86fddb9e4263b39dccb0e959f5e46210be7e3516
Author: 1ambda <1a...@gmail.com>
Date: 2016-12-30T06:55:33Z
fix: Remove grunt-contrib-clean
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1824
Since this PR merge, [first CI test profile fails](https://travis-ci.org/apache/zeppelin/jobs/188757727) with
```
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm clean) on project zeppelin-web: Failed to run task: 'npm run clean' failed. java.io.IOException: Cannot run program "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" (in directory "/home/travis/build/apache/zeppelin/zeppelin-web"): error=2, No such file or directory -> [Help 1]
```
@1ambda Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (gru...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1824
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1824
`mvn clean` in `zeppelin-web` module now removes [`bower_components`](https://github.com/apache/zeppelin/blob/master/zeppelin-web/pom.xml#L180).
what do you think about making `mvn clean` run `npm run clean` as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1824
LGTM and merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1824
@Leemoonsoo Thanks for review!
Now `mvn clean` will execute `npm run clean` (8baaea2)
```
$ zeppelin-web git:(ZEPPELIN-1850/remove-grunt-clean) mvn clean
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; support was removed in8.0
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Zeppelin: web Application 0.7.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ zeppelin-web ---
[INFO] Deleting /Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/target
[INFO]
[INFO] --- frontend-maven-plugin:1.3:npm (npm clean) @ zeppelin-web ---
[INFO] Running 'npm run clean' in /Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web
[INFO]
[INFO] > zeppelin-web@0.0.0 clean /Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web
[INFO] > rimraf dist && rimraf .tmp
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---