You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by olegz <gi...@git.apache.org> on 2016/10/14 16:52:38 UTC

[GitHub] nifi pull request #1130: NIFI-2819: Added support for Expression Language in...

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1130#discussion_r83460093
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ModifyBytes.java ---
    @@ -66,13 +66,15 @@
                 .required(true)
                 .addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
                 .defaultValue("0 B")
    +            .expressionLanguageSupported(true)
                 .build();
         public static final PropertyDescriptor END_OFFSET = new PropertyDescriptor.Builder()
                 .name("End Offset")
    --- End diff --
    
    When I saw _end-offset_  i got confused since the next offset is the end offset, but description states its _Number of bytes removed at the end of the file_. This means it's not an offset at all.
    I know this is not part of the immediate issue, but at least consider raising an improvement JIRA where this could be fixed. Obviously we can't change the _name_, so we'll keep it, but we can add _displayProperty(..)_


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---