You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/24 02:50:28 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
LuciferYang opened a new pull request, #38365:
URL: https://github.com/apache/spark/pull/38365
### What changes were proposed in this pull request?
The main change of this pr as follows:
- Replace `Antarctica/Vostok` to `Asia/Urumqi` in Spark code
- Replace `Europe/Amsterdam` to `Europe/Brussels` in Spark code
- Regenerate `gregorian-julian-rebase-micros.json` using generate 'gregorian-julian-rebase-micros.json' in `RebaseDateTimeSuite` with Java 8u352
- Regenerate `julian-gregorian-rebase-micros.json` using generate 'julian-gregorian-rebase-micros.json' in RebaseDateTimeSuite with Java 8u352
### Why are the changes needed?
Make GA run successfully with the latest Java 8/11/17:
- Java 8u352
- Java 11.0.17
- Java 17.0.5
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Pass GitHub Actions
- Manual test: the following commands can test pass with Java 8u345, 8u352, 11.0.16, 11.0.17, 17.0.4 and 17.0.5
- `build/sbt "catalyst/test"`
- `build/sbt "sql/testOnly *SQLQueryTestSuite -- -t \"timestamp-ltz.sql\""`
- `build/sbt "sql/testOnly *SQLQueryTestSuite -- -t \"timestamp-ntz.sql\""`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
URL: https://github.com/apache/spark/pull/38365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38365:
URL: https://github.com/apache/spark/pull/38365#issuecomment-1288545420
Merged to branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38365:
URL: https://github.com/apache/spark/pull/38365#issuecomment-1288620140
Thanks @HyukjinKwon @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38365:
URL: https://github.com/apache/spark/pull/38365#issuecomment-1288536202
https://github.com/LuciferYang/spark/actions/runs/3309640149/jobs/5464365656
```
ImportError: Missing optional dependency 'Jinja2'. DataFrame.style requires jinja2. Use pip or conda to install Jinja2.
----------------------------------------------------------------------
Ran 153 tests in 332.174s
FAILED (errors=1, skipped=3)
Generating XML reports...
Had test failures in pyspark.pandas.tests.test_dataframe with python3.6; see logs.
Error: running /__w/spark/spark/python/run-tests --modules=pyspark-pandas-slow --parallelism=1 --python-executable=python3.6,python3.9,pypy3 ; received return code 255
Error: Process completed with exit code 19.
```
https://github.com/LuciferYang/spark/actions/runs/3309640149/jobs/5464366180
```
starting pycodestyle test...
pycodestyle checks failed:
./python/pyspark/ml/tests/test_tuning.py:203:23: E275 missing whitespace after keyword
./python/pyspark/broadcast.py:102:23: E275 missing whitespace after keyword
./python/pyspark/sql/pandas/conversion.py:174:20: E275 missing whitespace after keyword
./python/pyspark/sql/readwriter.py:662:60: E275 missing whitespace after keyword
./python/pyspark/sql/readwriter.py:694:60: E275 missing whitespace after keyword
./python/pyspark/sql/tests/test_pandas_udf_grouped_agg.py:512:[15](https://github.com/LuciferYang/spark/actions/runs/3309640149/jobs/5464366180#step:14:16): E275 missing whitespace after keyword
./python/pyspark/sql/tests/test_context.py:[16](https://github.com/LuciferYang/spark/actions/runs/3309640149/jobs/5464366180#step:14:17)6:[19](https://github.com/LuciferYang/spark/actions/runs/3309640149/jobs/5464366180#step:14:20): E275 missing whitespace after keyword
./python/pyspark/worker.py:583:27: E275 missing whitespace after keyword
```
@HyukjinKwon Known issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38365:
URL: https://github.com/apache/spark/pull/38365#issuecomment-1288545165
Yeah, let's just get this in first.
@itholic mind taking a look when you find some time? The tests fail in branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38365: [SPARK-40851][INFRA ][SQL][TESTS][3.2] Make GA run successfully with the latest Java 8/11/17
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38365:
URL: https://github.com/apache/spark/pull/38365#issuecomment-1288342632
waiting ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org