You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2014/07/02 17:48:25 UTC

[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code

    [ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050221#comment-14050221 ] 

Jun Rao commented on KAFKA-1513:
--------------------------------

Thanks for the patch. Could server be just val?

> Cleanup KafkaServerStartable code
> ---------------------------------
>
>                 Key: KAFKA-1513
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1513
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>            Reporter: Evgeny Vereshchagin
>            Priority: Minor
>         Attachments: cleanup-kafkaserverstartable-code-v1.patch
>
>
> [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand.
> Var initialization would be simpler for readers.
> Patch will be soon. It's my first time:)



--
This message was sent by Atlassian JIRA
(v6.2#6252)