You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2010/06/16 19:15:53 UTC

svn commit: r955306 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/revs-txns.c libsvn_fs_base/revs-txns.h libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h

Author: danielsh
Date: Wed Jun 16 17:15:52 2010
New Revision: 955306

URL: http://svn.apache.org/viewvc?rev=955306&view=rev
Log:
Constify a parameter.

Suggested by: julianfoad

* subversion/include/svn_fs.h
  (svn_fs_change_rev_prop2):
* subversion/libsvn_fs/fs-loader.h
  (fs_vtable_t.change_rev_prop):
* subversion/libsvn_fs/fs-loader.c
  (svn_fs_change_rev_prop2):
    Make the OLD_VALUE_P member/parameter more const.

* subversion/libsvn_fs_base/revs-txns.h
  (svn_fs_base__set_rev_prop, svn_fs_base__change_rev_prop):
* subversion/libsvn_fs_base/revs-txns.c
  (svn_fs_base__set_rev_prop, change_rev_prop_args,
   svn_fs_base__change_rev_prop):
    Make the OLD_VALUE_P member/parameter more const.

* subversion/libsvn_fs_fs/fs_fs.c
  (change_rev_prop_baton, svn_fs_fs__change_rev_prop):
* subversion/libsvn_fs_fs/fs_fs.h
  (svn_fs_fs__change_rev_prop):
    Make the OLD_VALUE_P member/parameter more const.

Modified:
    subversion/trunk/subversion/include/svn_fs.h
    subversion/trunk/subversion/libsvn_fs/fs-loader.c
    subversion/trunk/subversion/libsvn_fs/fs-loader.h
    subversion/trunk/subversion/libsvn_fs_base/revs-txns.c
    subversion/trunk/subversion/libsvn_fs_base/revs-txns.h
    subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
    subversion/trunk/subversion/libsvn_fs_fs/fs_fs.h

Modified: subversion/trunk/subversion/include/svn_fs.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_fs.h?rev=955306&r1=955305&r2=955306&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_fs.h (original)
+++ subversion/trunk/subversion/include/svn_fs.h Wed Jun 16 17:15:52 2010
@@ -1913,7 +1913,7 @@ svn_error_t *
 svn_fs_change_rev_prop2(svn_fs_t *fs,
                         svn_revnum_t rev,
                         const char *name,
-                        const svn_string_t **old_value_p,
+                        const svn_string_t *const *old_value_p,
                         const svn_string_t *value,
                         apr_pool_t *pool);
 

Modified: subversion/trunk/subversion/libsvn_fs/fs-loader.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs/fs-loader.c?rev=955306&r1=955305&r2=955306&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs/fs-loader.c (original)
+++ subversion/trunk/subversion/libsvn_fs/fs-loader.c Wed Jun 16 17:15:52 2010
@@ -1200,7 +1200,7 @@ svn_fs_revision_proplist(apr_hash_t **ta
 
 svn_error_t *
 svn_fs_change_rev_prop2(svn_fs_t *fs, svn_revnum_t rev, const char *name,
-                        const svn_string_t **old_value_p,
+                        const svn_string_t *const *old_value_p,
                         const svn_string_t *value, apr_pool_t *pool)
 {
   return svn_error_return(fs->vtable->change_rev_prop(fs, rev, name,

Modified: subversion/trunk/subversion/libsvn_fs/fs-loader.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs/fs-loader.h?rev=955306&r1=955305&r2=955306&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs/fs-loader.h (original)
+++ subversion/trunk/subversion/libsvn_fs/fs-loader.h Wed Jun 16 17:15:52 2010
@@ -158,7 +158,7 @@ typedef struct fs_vtable_t
                                     svn_revnum_t rev, apr_pool_t *pool);
   svn_error_t *(*change_rev_prop)(svn_fs_t *fs, svn_revnum_t rev,
                                   const char *name,
-                                  const svn_string_t **old_value_p,
+                                  const svn_string_t *const *old_value_p,
                                   const svn_string_t *value,
                                   apr_pool_t *pool);
   svn_error_t *(*get_uuid)(svn_fs_t *fs, const char **uuid, apr_pool_t *pool);

Modified: subversion/trunk/subversion/libsvn_fs_base/revs-txns.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/revs-txns.c?rev=955306&r1=955305&r2=955306&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/revs-txns.c (original)
+++ subversion/trunk/subversion/libsvn_fs_base/revs-txns.c Wed Jun 16 17:15:52 2010
@@ -241,7 +241,7 @@ svn_error_t *
 svn_fs_base__set_rev_prop(svn_fs_t *fs,
                           svn_revnum_t rev,
                           const char *name,
-                          const svn_string_t **old_value_p,
+                          const svn_string_t *const *old_value_p,
                           const svn_string_t *value,
                           trail_t *trail,
                           apr_pool_t *pool)
@@ -287,7 +287,7 @@ svn_fs_base__set_rev_prop(svn_fs_t *fs,
 struct change_rev_prop_args {
   svn_revnum_t rev;
   const char *name;
-  const svn_string_t **old_value_p;
+  const svn_string_t *const *old_value_p;
   const svn_string_t *value;
 };
 
@@ -307,7 +307,7 @@ svn_error_t *
 svn_fs_base__change_rev_prop(svn_fs_t *fs,
                              svn_revnum_t rev,
                              const char *name,
-                             const svn_string_t **old_value_p,
+                             const svn_string_t *const *old_value_p,
                              const svn_string_t *value,
                              apr_pool_t *pool)
 {

Modified: subversion/trunk/subversion/libsvn_fs_base/revs-txns.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/revs-txns.h?rev=955306&r1=955305&r2=955306&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/revs-txns.h (original)
+++ subversion/trunk/subversion/libsvn_fs_base/revs-txns.h Wed Jun 16 17:15:52 2010
@@ -61,7 +61,7 @@ svn_error_t *svn_fs_base__rev_get_txn_id
 svn_error_t *svn_fs_base__set_rev_prop(svn_fs_t *fs,
                                        svn_revnum_t rev,
                                        const char *name,
-                                       const svn_string_t **old_value_p,
+                                       const svn_string_t *const *old_value_p,
                                        const svn_string_t *value,
                                        trail_t *trail,
                                        apr_pool_t *pool);
@@ -181,7 +181,7 @@ svn_error_t *svn_fs_base__revision_propl
 
 svn_error_t *svn_fs_base__change_rev_prop(svn_fs_t *fs, svn_revnum_t rev,
                                           const char *name,
-                                          const svn_string_t **old_value_p,
+                                          const svn_string_t *const *old_value_p,
                                           const svn_string_t *value,
                                           apr_pool_t *pool);
 

Modified: subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c?rev=955306&r1=955305&r2=955306&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Wed Jun 16 17:15:52 2010
@@ -7167,7 +7167,7 @@ struct change_rev_prop_baton {
   svn_fs_t *fs;
   svn_revnum_t rev;
   const char *name;
-  const svn_string_t **old_value_p;
+  const svn_string_t *const *old_value_p;
   const svn_string_t *value;
 };
 
@@ -7209,7 +7209,7 @@ svn_error_t *
 svn_fs_fs__change_rev_prop(svn_fs_t *fs,
                            svn_revnum_t rev,
                            const char *name,
-                           const svn_string_t **old_value_p,
+                           const svn_string_t *const *old_value_p,
                            const svn_string_t *value,
                            apr_pool_t *pool)
 {

Modified: subversion/trunk/subversion/libsvn_fs_fs/fs_fs.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/fs_fs.h?rev=955306&r1=955305&r2=955306&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/fs_fs.h (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.h Wed Jun 16 17:15:52 2010
@@ -445,7 +445,7 @@ svn_error_t *svn_fs_fs__revision_prop(sv
    preexisting value is *OLD_VALUE_P.  Do any temporary allocation in POOL.  */
 svn_error_t *svn_fs_fs__change_rev_prop(svn_fs_t *fs, svn_revnum_t rev,
                                         const char *name,
-                                        const svn_string_t **old_value_p,
+                                        const svn_string_t *const *old_value_p,
                                         const svn_string_t *value,
                                         apr_pool_t *pool);