[GitHub] [hadoop-ozone] amaliujia commented on a change in pull request #1414: HDDS-4231. Background Service blocks on task results.

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #1414:
URL: https://github.com/apache/hadoop-ozone/pull/1414#discussion_r486505162



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/BackgroundService.java
##########
@@ -62,11 +56,11 @@ public BackgroundService(String serviceName, long interval,
     this.interval = interval;
     this.unit = unit;
     this.serviceName = serviceName;
-    this.serviceTimeout = serviceTimeout;
+    this.serviceTimeoutInNanos = TimeDuration.valueOf(serviceTimeout, unit)
+            .toLong(TimeUnit.NANOSECONDS);

Review comment:
       Usually long is not enough to contain NANOSECONDS but this variable seems just a service timeout, which should be a very small number so it should be fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org