You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/01 16:05:04 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #22995: [DONT MERGE]Python 3.10 with updated opcodes
AnandInguva opened a new pull request, #22995:
URL: https://github.com/apache/beam/pull/22995
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22995: [WIP]Python 3.10 with updated opcodes
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22995:
URL: https://github.com/apache/beam/pull/22995#issuecomment-1236513122
# [Codecov](https://codecov.io/gh/apache/beam/pull/22995?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22995](https://codecov.io/gh/apache/beam/pull/22995?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b0d9ea) into [master](https://codecov.io/gh/apache/beam/commit/e880fdbfc32d40f2ce29d3b4bd5a8f6392218f8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e880fdb) will **decrease** coverage by `0.82%`.
> The diff coverage is `80.00%`.
```diff
@@ Coverage Diff @@
## master #22995 +/- ##
==========================================
- Coverage 73.90% 73.07% -0.83%
==========================================
Files 713 710 -3
Lines 94464 93642 -822
==========================================
- Hits 69809 68430 -1379
- Misses 23358 23944 +586
+ Partials 1297 1268 -29
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.93% <80.00%> (-1.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22995?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `77.34% <ø> (ø)` | |
| [sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL29wY29kZXMucHk=) | `84.64% <50.00%> (-0.25%)` | :arrow_down: |
| [.../python/apache\_beam/typehints/trivial\_inference.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3RyaXZpYWxfaW5mZXJlbmNlLnB5) | `96.15% <87.50%> (-0.27%)` | :arrow_down: |
| [...i/org/apache/beam/model/pipeline/v1/metrics\_pb2.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL29yZy9hcGFjaGUvYmVhbS9tb2RlbC9waXBlbGluZS92MS9tZXRyaWNzX3BiMi5weQ==) | `21.08% <0.00%> (-78.92%)` | :arrow_down: |
| [...ache/beam/model/pipeline/v1/beam\_runner\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL29yZy9hcGFjaGUvYmVhbS9tb2RlbC9waXBlbGluZS92MS9iZWFtX3J1bm5lcl9hcGlfcGIyLnB5) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [.../beam/model/pipeline/v1/standard\_window\_fns\_pb2.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL29yZy9hcGFjaGUvYmVhbS9tb2RlbC9waXBlbGluZS92MS9zdGFuZGFyZF93aW5kb3dfZm5zX3BiMi5weQ==) | `51.85% <0.00%> (-48.15%)` | :arrow_down: |
| [...ache/beam/model/fn\_execution/v1/beam\_fn\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL29yZy9hcGFjaGUvYmVhbS9tb2RlbC9mbl9leGVjdXRpb24vdjEvYmVhbV9mbl9hcGlfcGIyLnB5) | `52.84% <0.00%> (-47.16%)` | :arrow_down: |
| [...m/model/job\_management/v1/beam\_artifact\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL29yZy9hcGFjaGUvYmVhbS9tb2RlbC9qb2JfbWFuYWdlbWVudC92MS9iZWFtX2FydGlmYWN0X2FwaV9wYjIucHk=) | `57.72% <0.00%> (-42.28%)` | :arrow_down: |
| [...e/beam/model/job\_management/v1/beam\_job\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL29yZy9hcGFjaGUvYmVhbS9tb2RlbC9qb2JfbWFuYWdlbWVudC92MS9iZWFtX2pvYl9hcGlfcGIyLnB5) | `60.81% <0.00%> (-39.19%)` | :arrow_down: |
| [.../model/job\_management/v1/beam\_expansion\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL29yZy9hcGFjaGUvYmVhbS9tb2RlbC9qb2JfbWFuYWdlbWVudC92MS9iZWFtX2V4cGFuc2lvbl9hcGlfcGIyLnB5) | `61.29% <0.00%> (-38.71%)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/beam/pull/22995/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22995: [WIP]Python 3.10 with updated opcodes
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22995:
URL: https://github.com/apache/beam/pull/22995#issuecomment-1241956141
I was worried about that since my PR didn't run any tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva closed pull request #22995: [WIP]Python 3.10 with updated opcodes
Posted by GitBox <gi...@apache.org>.
AnandInguva closed pull request #22995: [WIP]Python 3.10 with updated opcodes
URL: https://github.com/apache/beam/pull/22995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22995: [DONT MERGE]Python 3.10 with updated opcodes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22995:
URL: https://github.com/apache/beam/pull/22995#issuecomment-1234671688
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22995: [WIP]Python 3.10 with updated opcodes
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22995:
URL: https://github.com/apache/beam/pull/22995#issuecomment-1241964910
Working on a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22995: [WIP]Python 3.10 with updated opcodes
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22995:
URL: https://github.com/apache/beam/pull/22995#issuecomment-1241948248
@yeandy https://github.com/apache/beam/pull/22995/commits/6a1b277fb4065040111abd9143a34b984f8dba0f this is causing a lot of errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22995: [WIP]Python 3.10 with updated opcodes
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22995:
URL: https://github.com/apache/beam/pull/22995#issuecomment-1242152368
> Working on a fix
Thanks Andy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org