[GitHub] [beam] KevinGG commented on a change in pull request #11898: [BEAM-10178] Improved error messages when option is not set

[GitBox <gi...@apache.org>]

KevinGG commented on a change in pull request #11898:
URL: https://github.com/apache/beam/pull/11898#discussion_r434212247



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1702,7 +1702,8 @@ def _get_destination_uri(self, temp_location):
       logging.debug("gcs_location is empty, using temp_location instead")
     else:
       raise ValueError(
-          '{} requires a GCS location to be provided'.format(
+          '{} requires a GCS location to be provided. Neither option'
+          '--gcs_location nor the fallback --temp_location is set.'.format(

Review comment:
       Thanks for the correction, Pablo!
   
   It looks like that Java and Python handles the usage of temp location for bigquery io differently.
   Java's `Read` only uses and validates `tempLocation` but `Write` takes `customGcsLocation` and falls back to `tempLocation`.
   Python's `Read` takes `gcs_location` and falls back to `temp_location` while `Write` takes `custom_gcs_temp_location` and falls back to `temp_location`.
   
   It seems that Java's `Read` should also allow specifying a `gcsLocation`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org