You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/09/13 18:14:35 UTC
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18980
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
IMPALA-11578: Exclude locality test for remote FS
Exclude test_scheduler_locality when the filesystem can only be remote.
Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
---
M tests/common/skip.py
M tests/custom_cluster/test_scheduler_locality.py
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/18980/1
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
Patch Set 4:
Oh sorry, missed that somewhere.
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 16:34:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
Patch Set 2:
Running the test suite with Ozone. I'll update when it passes.
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 21:10:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
IMPALA-11578: Exclude locality test for remote FS
Exclude test_scheduler_locality when the filesystem can only be remote.
Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
---
M tests/common/skip.py
M tests/custom_cluster/test_scheduler_locality.py
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/18980/4
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
IMPALA-11578: Exclude locality test for remote FS
Exclude test_scheduler_locality when the filesystem can only be remote.
Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Reviewed-on: http://gerrit.cloudera.org:8080/18980
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/skip.py
M tests/custom_cluster/test_scheduler_locality.py
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18980
to look at the new patch set (#2).
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
IMPALA-11578: Exclude locality test for remote FS
Exclude test_scheduler_locality when the filesystem can only be remote.
Updates SkipOfNotHdfsMinicluster to also run on Ozone, enabling several
dozen more tests for Ozone.
Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
---
M tests/common/skip.py
M tests/custom_cluster/test_scheduler_locality.py
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/18980/2
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11349/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 21:28:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 01:00:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
Patch Set 2:
Ran into ~20 failures I don't have the time to parse at the moment, so I've reverted this to a more limited change.
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 16:49:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11381/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 16:55:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11578: Exclude locality test for remote FS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18980 )
Change subject: IMPALA-11578: Exclude locality test for remote FS
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11348/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6198421f21bc2520773ecbb34ffaf65969ebc43
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 18:35:45 +0000
Gerrit-HasComments: No