You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/11/04 15:21:20 UTC

DO NOT REPLY [Bug 52136] New: [PATCH] Build.xml simplification and JUnit regex

https://issues.apache.org/bugzilla/show_bug.cgi?id=52136

             Bug #: 52136
           Summary: [PATCH] Build.xml simplification and JUnit regex
           Product: Fop
           Version: 1.0
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: med1985@gmail.com
    Classification: Unclassified


Created attachment 27895
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27895
Junit-regex patch

This patch changes the build.xml file to reduce some of the code-duplication.
It also introduces a regex for finding the Junit test files, the reason I've
done this is because some of the tests were being ignored because they didn't
appear in a TestSuite. I also think the output produced by junit on the command
line more readable.

However, in order to use a regex (**/*TestCase.java), this means that any class
in the test file that isn't intended to run (helper files or abstract classes)
cannot be called *TestCase.java. I think that's a fairly well established
tradition.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52136] [PATCH] Build.xml simplification and JUnit regex

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52136

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52136] [PATCH] Build.xml simplification and JUnit regex

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52136

Vincent Hennebert <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Vincent Hennebert <vh...@gmail.com> 2011-11-07 18:19:57 UTC ---
Patch applied in rev. 1198853:
http://svn.apache.org/viewvc?revision=1198853&view=revision

I inferred from the patch the files that were renamed, in order to preserve
Subversion history. In the future it would be helpful if you could list the
files that you renamed and to what.

I removed the junit-full target which no longer has a utility.

Thanks!
Vincent

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.