You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/23 09:38:20 UTC
[GitHub] [apisix-go-plugin-runner] spacewander opened a new pull request #11: ci: perform CodeQL analysis
spacewander opened a new pull request #11:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on a change in pull request #11: ci: perform CodeQL analysis
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #11:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/11#discussion_r656931802
##########
File path: .github/workflows/codeql-analysis.yml
##########
@@ -0,0 +1,71 @@
+# For most projects, this workflow file will not need changing; you simply need
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #11: ci: perform CodeQL analysis
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #11:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #11: ci: perform CodeQL analysis
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/11#issuecomment-866688470
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d231f21) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/6e33fa657de759343f0a257c8de74fe635bd7da5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e33fa6) will **decrease** coverage by `2.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 81.60% 79.06% -2.54%
==========================================
Files 8 8
Lines 473 473
==========================================
- Hits 386 374 -12
- Misses 69 80 +11
- Partials 18 19 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `66.96% <0.00%> (-10.72%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6e33fa6...d231f21](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #11: ci: perform CodeQL analysis
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/11#issuecomment-866688470
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4c4e85) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/6e33fa657de759343f0a257c8de74fe635bd7da5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e33fa6) will **decrease** coverage by `2.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 81.60% 79.06% -2.54%
==========================================
Files 8 8
Lines 473 473
==========================================
- Hits 386 374 -12
- Misses 69 80 +11
- Partials 18 19 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `66.96% <0.00%> (-10.72%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6e33fa6...a4c4e85](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/11?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] tokers commented on a change in pull request #11: ci: perform CodeQL analysis
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #11:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/11#discussion_r656931106
##########
File path: .github/workflows/codeql-analysis.yml
##########
@@ -0,0 +1,71 @@
+# For most projects, this workflow file will not need changing; you simply need
Review comment:
We don't need the ASF license header for this file? As I saw the header is added for other workflow files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] github-actions[bot] commented on a change in pull request #11: ci: perform CodeQL analysis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on a change in pull request #11:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/11#discussion_r656930947
##########
File path: .github/workflows/codeql-analysis.yml
##########
@@ -0,0 +1,71 @@
+# For most projects, this workflow file will not need changing; you simply need
Review comment:
```suggestion
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
# For most projects, this workflow file will not need changing; you simply need
```
<!-- license-eye hidden identification -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org