You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tibor Digana (JIRA)" <ji...@apache.org> on 2018/12/11 10:31:00 UTC

[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

    [ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716792#comment-16716792 ] 

Tibor Digana edited comment on SUREFIRE-1546 at 12/11/18 10:30 AM:
-------------------------------------------------------------------

[~dantran]
Some work has been done in [1] but the implementation is still incomplete and I have objections to the change done in {{SimpleReportEntry}}. The string should be possibly passed to the current place where normally the method name resides. We do not have an IT which could drive us towards the implementation. 
Any volunteer to open a pull request on GitHub and collaborate on the implementation?

[1] https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1546-ReportEntry-DisplayName

[~OKrutova]
I would assign release version after we have got the implementation and a consensus in a review.



was (Author: tibor17):
[~dantran]
Some work has been done in [1] but I have objections to the change done in {{SimpleReportEntry}}. The string possibly should be passed to the current place where normally resides the method name. We do not have an IT which could drive us towards the implementation. Any volunteer to open a pull request on GitHub and collaborate on the implementation?

[1] https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1546-ReportEntry-DisplayName

[~OKrutova]
I would assign release version after we have got the implementation and a consensus in a review.


> JUnit 5 runner does not honor JUnit 5 display names
> ---------------------------------------------------
>
>                 Key: SUREFIRE-1546
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: JUnit 5.x support
>    Affects Versions: 2.22.0
>            Reporter: Romain Manni-Bucau
>            Assignee: Christian Stein
>            Priority: Major
>              Labels: junit5
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the classname if any is defined. Seems last release doesn't support that feature of JUnit 5 making the console output and reports not the expected ones.
>  
> Origin: https://github.com/junit-team/junit5/issues/990



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)