You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/07/19 13:53:29 UTC
[GitHub] [hive] klcopp opened a new pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
klcopp opened a new pull request #2495:
URL: https://github.com/apache/hive/pull/2495
### Why are the changes needed?
See HIVE-25348
### How was this patch tested?
Unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter commented on a change in pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
lcspinter commented on a change in pull request #2495:
URL: https://github.com/apache/hive/pull/2495#discussion_r672320320
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands3.java
##########
@@ -604,4 +605,14 @@ private void assertOneTxn() throws Exception {
Assert.assertEquals(TestTxnDbUtil.queryToString(hiveConf, "select * from TXNS"), 1,
TestTxnDbUtil.countQueryAgent(hiveConf, "select count(*) from TXNS"));
}
+
+ @Test public void testWritesToDisabledCompactionTableCtas() throws Exception {
Review comment:
nit: method declaration in new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp closed pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
klcopp closed pull request #2495:
URL: https://github.com/apache/hive/pull/2495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter commented on a change in pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
lcspinter commented on a change in pull request #2495:
URL: https://github.com/apache/hive/pull/2495#discussion_r672320320
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands3.java
##########
@@ -604,4 +605,14 @@ private void assertOneTxn() throws Exception {
Assert.assertEquals(TestTxnDbUtil.queryToString(hiveConf, "select * from TXNS"), 1,
TestTxnDbUtil.countQueryAgent(hiveConf, "select count(*) from TXNS"));
}
+
+ @Test public void testWritesToDisabledCompactionTableCtas() throws Exception {
Review comment:
nit: method declaration in new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
klcopp commented on pull request #2495:
URL: https://github.com/apache/hive/pull/2495#issuecomment-883238490
moved to https://github.com/apache/hive/pull/2497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp closed pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
klcopp closed pull request #2495:
URL: https://github.com/apache/hive/pull/2495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
klcopp commented on pull request #2495:
URL: https://github.com/apache/hive/pull/2495#issuecomment-883238490
moved to https://github.com/apache/hive/pull/2497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter commented on a change in pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
lcspinter commented on a change in pull request #2495:
URL: https://github.com/apache/hive/pull/2495#discussion_r672320320
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands3.java
##########
@@ -604,4 +605,14 @@ private void assertOneTxn() throws Exception {
Assert.assertEquals(TestTxnDbUtil.queryToString(hiveConf, "select * from TXNS"), 1,
TestTxnDbUtil.countQueryAgent(hiveConf, "select count(*) from TXNS"));
}
+
+ @Test public void testWritesToDisabledCompactionTableCtas() throws Exception {
Review comment:
nit: method declaration in new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp closed pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
klcopp closed pull request #2495:
URL: https://github.com/apache/hive/pull/2495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp closed pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
klcopp closed pull request #2495:
URL: https://github.com/apache/hive/pull/2495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on pull request #2495: HIVE-25348: Skip metrics collection about writes to tables with tblproperty no_auto_compaction=true if CTAS
Posted by GitBox <gi...@apache.org>.
klcopp commented on pull request #2495:
URL: https://github.com/apache/hive/pull/2495#issuecomment-883238490
moved to https://github.com/apache/hive/pull/2497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org