[GitHub] mdeuser commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

[GitBox <gi...@apache.org>]

mdeuser commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests
URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178856839
 
 

 ##########
 File path: tests/src/test/scala/system/basic/WskRuleTests.scala
 ##########
 @@ -102,21 +103,28 @@ abstract class WskRuleTests extends TestHelpers with WskTestHelpers {
       case (trigger, status) =>
         if (status == active) wsk.rule.enable(ruleName) else wsk.rule.disable(ruleName)
 
-        // Needs to be retried since the enable/disable causes a cache invalidation which needs to propagate first
-        retry(
-          {
-            wsk.rule
-              .create(ruleName, trigger, actionName, update = true)
-              .stdout
-              .parseJson
-              .asJsObject
-              .fields
-              .get("status") shouldBe status
-
-            wsk.rule.get(ruleName).stdout.parseJson.asJsObject.fields.get("status") shouldBe status
-          },
-          10,
-          Some(1.second))
+        if (cli) {
 
 Review comment:
   example cli header removal method
   https://github.com/apache/incubator-openwhisk/blob/f64722498bc2f5eadc356b3ae26ebb85de1bcdbf/tests/src/test/scala/common/WskTestHelpers.scala#L278

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services