You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/07/03 05:34:00 UTC

[GitHub] spark pull request #18441: [SPARK-21137][CORE] Spark reads many small files ...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18441#discussion_r125212029
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/BinaryFileRDD.scala ---
    @@ -35,8 +36,12 @@ private[spark] class BinaryFileRDD[T](
       extends NewHadoopRDD[String, T](sc, inputFormatClass, keyClass, valueClass, conf) {
     
       override def getPartitions: Array[Partition] = {
    -    val inputFormat = inputFormatClass.newInstance
         val conf = getConf
    +    // setMinPartitions below will call FileInputFormat.listStatus(), which can be quite slow when
    +    // traversing a large number of directories and files. Parallelize it.
    +    conf.setIfUnset(FileInputFormat.LIST_STATUS_NUM_THREADS,
    +      Runtime.getRuntime.availableProcessors().toString)
    --- End diff --
    
    shall we use `CPU_CORES_PER_EXECUTOR`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org