You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/02/21 05:01:22 UTC
[GitHub] [yunikorn-core] wilfred-s opened a new pull request, #509: [YUNIKORN-1590] REST interface shows incorrect placeholder data
wilfred-s opened a new pull request, #509:
URL: https://github.com/apache/yunikorn-core/pull/509
### What is this PR for?
The REST interface does not initialise all fields for the placeholders correctly. The allocation DAO did not set the Placeholder or TaskGroupName. The Ask did not expose the originator flag.
Allocation code was duplicated for nodes and applications. This could lead to inconsistent data to be shown for the same object in one dump.
### What type of PR is it?
* [X] - Bug Fix
* [X] - Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #509: [YUNIKORN-1590] REST interface shows incorrect placeholder data
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #509:
URL: https://github.com/apache/yunikorn-core/pull/509#issuecomment-1452801761
> Are there any effect on handlers_test.go because of its source go file changes?
No there are no effects. The whole purpose of this was consistency without affecting the results in the output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #509: [YUNIKORN-1590] REST interface shows incorrect placeholder data
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #509:
URL: https://github.com/apache/yunikorn-core/pull/509#issuecomment-1437881933
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#509](https://codecov.io/gh/apache/yunikorn-core/pull/509?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f81c13f) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/87aff78ca890a4b3feabc3d5b3f91a9862ff1024?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87aff78) will **increase** coverage by `0.19%`.
> The diff coverage is `88.39%`.
```diff
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
+ Coverage 73.42% 73.62% +0.19%
==========================================
Files 69 69
Lines 10449 10436 -13
==========================================
+ Hits 7672 7683 +11
+ Misses 2529 2506 -23
+ Partials 248 247 -1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `80.50% <88.28%> (+3.30%)` | :arrow_up: |
| [pkg/webservice/state\_dump.go](https://codecov.io/gh/apache/yunikorn-core/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `70.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #509: [YUNIKORN-1590] REST interface shows incorrect placeholder data
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #509: [YUNIKORN-1590] REST interface shows incorrect placeholder data
URL: https://github.com/apache/yunikorn-core/pull/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org