You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/06 18:59:41 UTC

[GitHub] [airflow] andrewgodwin edited a comment on issue #9387: Use enum for task_states/dag_states

andrewgodwin edited a comment on issue #9387:
URL: https://github.com/apache/airflow/issues/9387#issuecomment-814363281


   I would like to ask, though - do we just want the type hinting here (in which case we can just declare a nice Literal type for the state tuples), or take on the problems that changing a tuple to an enum will cause? There's a few places in Airflow, and presumably in some third-party code, that presume they can do operations on `State.task_states` as if it were a sliceable/iterable.
   
   (and also SQLAlchemy will not like the Enum values, resulting in a lot of casting back to string)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org