You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2019/08/08 00:58:04 UTC

Review Request 71246: RANGER-2531: Removing a user from a group is not reflected properly in unix based sync

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71246/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2531
    https://issues.apache.org/jira/browse/RANGER-2531


Repository: ranger


Description
-------

Fixed code to updated user groups and update user role properly when a user is deleted from a group. Also fixed code to not force update role for every sync cycle even when there are no updates to user's group memberships.


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 24956e013 
  ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java ddab6294a 


Diff: https://reviews.apache.org/r/71246/diff/1/


Testing
-------

1. Verified all the exisitng unit tests are run successfully.
2. Also patched a test cluster and verified adding/deleting users from a group are updated properly
3. Verified the role updates are working as intended.


Thanks,

Sailaja Polavarapu


Re: Review Request 71246: RANGER-2531: Removing a user from a group is not reflected properly in unix based sync

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71246/#review217126
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Aug. 8, 2019, 12:58 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71246/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2019, 12:58 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2531
>     https://issues.apache.org/jira/browse/RANGER-2531
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Fixed code to updated user groups and update user role properly when a user is deleted from a group. Also fixed code to not force update role for every sync cycle even when there are no updates to user's group memberships.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 24956e013 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java ddab6294a 
> 
> 
> Diff: https://reviews.apache.org/r/71246/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Verified all the exisitng unit tests are run successfully.
> 2. Also patched a test cluster and verified adding/deleting users from a group are updated properly
> 3. Verified the role updates are working as intended.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>